New issue
Advanced search Search tips

Issue 593177 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , iOS , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

IDN is always displayed in punycode/ACE in Javascript dialog box

Project Member Reported by js...@chromium.org, Mar 9 2016

Issue description

* How to reproduce

0. Settings: Language - Add 'Korean' to Accept-Language list (will not be necessary soon once lang-dependency is removed)
1. Go to http://내도메인.한국
2. Press '검색' (white text in blue background)

* Expected result
  
The dialog box has 

  '내도메인.한국' says: 

  도메인명을 입력해 주세요.
  [ ] Prevent this page from creating additonal dialogs

* Actual 

  'xn-220b31.....xn-3e0b707e' says

  도메인명을 입력해 주세요.
  [ ] Prevent this page from creating additonal dialogs


ElideHost() does not convert hostname (stored as punycode/ACE in GURL) to Unicode as necessary. 


 

Comment 1 by js...@chromium.org, Mar 9 2016

Screenshot is attached for the current behavior. Note that the omnibox has the hostname in Unicode instead of punycode. 
punycode shown in dialog.png
340 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee46c77dbdf32a39912ba6589aabd8db51eaed29

commit ee46c77dbdf32a39912ba6589aabd8db51eaed29
Author: jshin <jshin@chromium.org>
Date: Thu Apr 07 00:16:42 2016

Convert hostnames in ACE to Unicode in ElideHost

Call IDNToUnicode to convert host (full fqdn) and domain to
Unicode (per the IDN display policy) in ElideHost

BUG= 593177 
TEST=components_unittests --gtest_filter= *HostEliding

Review URL: https://codereview.chromium.org/1861213002

Cr-Commit-Position: refs/heads/master@{#385598}

[modify] https://crrev.com/ee46c77dbdf32a39912ba6589aabd8db51eaed29/components/url_formatter/elide_url.cc
[modify] https://crrev.com/ee46c77dbdf32a39912ba6589aabd8db51eaed29/components/url_formatter/elide_url_unittest.cc

Comment 3 by js...@chromium.org, Apr 12 2016

Status: Fixed (was: Assigned)

Sign in to add a comment