New issue
Advanced search Search tips

Issue 593174 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

|Symbol.iterator in window| is true

Project Member Reported by tkent@chromium.org, Mar 9 2016

Issue description

Version: 51 canary + chrome://flags/#enable-experimental-web-platform-features enabled
OS: All

What steps will reproduce the problem?
(1) Open http://w3c-test.org/html/browsers/the-window-object/accessing-other-browsing-contexts/iterator.html

What is the expected output? What do you see instead?
Expected: The test passes.
Actual: The test fails.

Please use labels and text to provide additional information.
Due to crrev.com/355541
 
I think this is just a symptom of the feature not being shipped, and being behind a flag.

I'll send an intent-to-ship email tomorrow

Comment 2 by tkent@chromium.org, Mar 9 2016

> I think this is just a symptom of the feature not being shipped, and being behind a flag.

No.  This issue means enabling the feature breaks interoperability.
The test passes on Firefox and Edge.

Right, so there are a few confusing things here:

The test name sounds like it's referring to https://github.com/whatwg/html/pull/638, in particular the changes to internal methods for these cross origin accesses --- but the actual content of the test is not verifying this at all, due to not operating on a different browsing context at all. So I'm fairly sure the test itself is wrong.

Other than that, it looks like other browsers just don't implement the feature yet at all, which would explain why they pass an apparently incorrect test
I've filed https://github.com/w3c/web-platform-tests/issues/2664 to see if this is a test bug or not --- in the mean time, I doubt it's actually breaking any content anywhere, but if it is, lets remove the stuff adding @@iterator to window.

Comment 5 by tkent@chromium.org, Mar 9 2016

I don't think cross-origin access matters here.  Why does window have @@iterator?

It's in the WebIDL spec, https://heycam.github.io/webidl/#es-iterators

In particular: "window" has a "length" attribute, and an indexed getter --- thus, per WebIDL, it has @@iterator.

The test itself (if you look at the file name) is entirely related to accessing different browsing contexts, and all of the other tests in the directory excercise this. So it seems like this was probably intended to be about the restrictions on ES internal methods when talking to browsing contexts from a different domain, but I'd like to verify this with Ms2ger
After talking to bz about it, it sounds like there was a spec change to remove this feature from window, which Domenic should know something about.

So, I suppose we can go ahead and remove it from window.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 16 2016

Comment 9 by tkent@chromium.org, Mar 16 2016

Status: Fixed (was: Untriaged)

Sign in to add a comment