New issue
Advanced search Search tips

Issue 593166 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Remove the preferencesPrivate extension api

Project Member Reported by rdevlin....@chromium.org, Mar 8 2016

Issue description

It's not being used by anyone anymore, it seems.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76ea109e501ad804a4539f61028515d7ff9b7e07

commit 76ea109e501ad804a4539f61028515d7ff9b7e07
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Tue Mar 15 19:20:06 2016

[Extensions] Remove unused parts of the preferencesPrivate API

easyUnlockProximityRequired might still be used by someone, but it looks like
the rest of this API can be removed.

BUG=593166
TBR=erg@chromium.org (profiles/ pref change reviewed by gab@)

Review URL: https://codereview.chromium.org/1776373002

Cr-Commit-Position: refs/heads/master@{#381278}

[modify] https://crrev.com/76ea109e501ad804a4539f61028515d7ff9b7e07/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc
[delete] https://crrev.com/b8ec5143caf3fb0e2858e2abab6c1983eaa9462f/chrome/browser/extensions/api/preferences_private/preferences_private_api.cc
[delete] https://crrev.com/b8ec5143caf3fb0e2858e2abab6c1983eaa9462f/chrome/browser/extensions/api/preferences_private/preferences_private_api.h
[delete] https://crrev.com/b8ec5143caf3fb0e2858e2abab6c1983eaa9462f/chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc
[modify] https://crrev.com/76ea109e501ad804a4539f61028515d7ff9b7e07/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/76ea109e501ad804a4539f61028515d7ff9b7e07/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/76ea109e501ad804a4539f61028515d7ff9b7e07/chrome/chrome_browser_extensions.gypi
[modify] https://crrev.com/76ea109e501ad804a4539f61028515d7ff9b7e07/chrome/chrome_tests.gypi
[modify] https://crrev.com/76ea109e501ad804a4539f61028515d7ff9b7e07/chrome/common/extensions/api/preferences_private.json
[modify] https://crrev.com/76ea109e501ad804a4539f61028515d7ff9b7e07/chrome/common/pref_names.cc
[modify] https://crrev.com/76ea109e501ad804a4539f61028515d7ff9b7e07/chrome/common/pref_names.h

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f7ccd9b2b45c46f2cc791ce1e23b71bf1772604

commit 0f7ccd9b2b45c46f2cc791ce1e23b71bf1772604
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Thu Mar 17 19:09:33 2016

[Extensions] Update extension function/event histogram values

The preferencesPrivate, location, and principalsPrivate APIs have been
reduced/removed. Update the histogram values in one CL with nothing else since
presubmit complains about modifying values.

BUG= 595168 
BUG=593166
BUG= 586560 
NOTRY=true
(NOTRY because editing existing histogram entries in valid ways)

Review URL: https://codereview.chromium.org/1810583003

Cr-Commit-Position: refs/heads/master@{#381766}

[modify] https://crrev.com/0f7ccd9b2b45c46f2cc791ce1e23b71bf1772604/extensions/browser/extension_event_histogram_value.h
[modify] https://crrev.com/0f7ccd9b2b45c46f2cc791ce1e23b71bf1772604/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/0f7ccd9b2b45c46f2cc791ce1e23b71bf1772604/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc9b14e330b974af7651695a76f52b38b183d35b

commit fc9b14e330b974af7651695a76f52b38b183d35b
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Tue Aug 29 19:10:49 2017

[Extensions] Shrink the preferencesPrivate API

The preferencesPrivate API has been reduced to the easyUnlock
proximityRequired bit, which was originally used to read, set, and
monitor the easy_unlock.proximity_required preference. Since, the
unlock extension has largely migrated away from preferencesPrivate
towards its own private API and other tools. It no longer uses the
preferencesPrivate API to read or set the preference, and only uses
the onChange event.

Additionally, the easy_unlock.proximity_required preference no longer
exists (it was removed in
crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09), so there is a
guarantee that it will never change. This means that there is no
portion of the preferencesPrivate API that is still used, beyond
ensuring we don't break the existing code which still calls
easyUnlockProxmityRequired.onChange().

Reduce the preferencesPrivate API to only have a single event with the 
same name, which will never be called.  This allows us to also remove 
the entirety of the types_private.json API and the implementation of 
ChromeDirectSettings. 

Bug: 593166
Bug:  263822 

TBR=dpapad@chromium.org (renderer_resources.grd change)

Change-Id: Ieb349a7c6789be14d7fcad68450306f8467e723f
Reviewed-on: https://chromium-review.googlesource.com/636773
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498188}
[modify] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/chrome/browser/extensions/BUILD.gn
[delete] https://crrev.com/c99ebede6f15e72b0f98358b8e710353c6357abc/chrome/browser/extensions/api/preference/chrome_direct_setting.cc
[delete] https://crrev.com/c99ebede6f15e72b0f98358b8e710353c6357abc/chrome/browser/extensions/api/preference/chrome_direct_setting.h
[delete] https://crrev.com/c99ebede6f15e72b0f98358b8e710353c6357abc/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc
[delete] https://crrev.com/c99ebede6f15e72b0f98358b8e710353c6357abc/chrome/browser/extensions/api/preference/chrome_direct_setting_api.h
[add] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/chrome/browser/extensions/api/preference/preferences_private_apitest.cc
[modify] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/chrome/browser/extensions/browser_context_keyed_service_factories.cc
[modify] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/chrome/browser/extensions/chrome_extensions_browser_client.cc
[modify] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/chrome/common/extensions/api/BUILD.gn
[modify] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/chrome/common/extensions/api/preferences_private.json
[delete] https://crrev.com/c99ebede6f15e72b0f98358b8e710353c6357abc/chrome/common/extensions/api/types_private.json
[modify] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/chrome/renderer/BUILD.gn
[modify] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
[add] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/chrome/renderer/resources/extensions/easy_unlock_proximity_required.js
[modify] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/chrome/renderer/resources/renderer_resources.grd
[modify] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/chrome/test/BUILD.gn
[add] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/chrome/test/data/extensions/api_test/preferences_private/manifest.json
[add] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/chrome/test/data/extensions/api_test/preferences_private/test.js
[modify] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/extensions/browser/extension_event_histogram_value.h
[modify] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/extensions/renderer/BUILD.gn
[add] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/extensions/renderer/easy_unlock_proximity_required_stub.cc
[add] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/extensions/renderer/easy_unlock_proximity_required_stub.h
[modify] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/extensions/renderer/native_extension_bindings_system.cc
[modify] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/extensions/renderer/resources/binding.js
[modify] https://crrev.com/fc9b14e330b974af7651695a76f52b38b183d35b/tools/metrics/histograms/enums.xml

Cc: -asargent@chromium.org

Sign in to add a comment