Sounds like something is getting logged to stdout that shouldn't be ...

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/e358eab8962e788ce75c016d680ec78fa06ddb12

commit e358eab8962e788ce75c016d680ec78fa06ddb12
Author: krasin@google.com <krasin@google.com>
Date: Wed Mar 09 04:56:58 2016

Clang upload bots: don't run hooks or mb.

These bots don't need anything like that. It also sames a trouble
of dealing with update.py being called as a part of runhooks,
which would try to download Clang binaries which don't yet exist.

BUG=593154, 578306 

Review URL: https://codereview.chromium.org/1776893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299171 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/e358eab8962e788ce75c016d680ec78fa06ddb12/scripts/slave/recipes/chromium_clang_upload.expected/full_tryserver_chromium_linux_linux_chromium_clang_upload.json
[modify] https://crrev.com/e358eab8962e788ce75c016d680ec78fa06ddb12/scripts/slave/recipes/chromium_clang_upload.expected/full_tryserver_chromium_mac_mac_chromium_clang_upload.json
[modify] https://crrev.com/e358eab8962e788ce75c016d680ec78fa06ddb12/scripts/slave/recipes/chromium_clang_upload.expected/full_tryserver_chromium_win_win8_chromium_clang_upload.json
[modify] https://crrev.com/e358eab8962e788ce75c016d680ec78fa06ddb12/scripts/slave/recipes/chromium_clang_upload.py

I'm not sure if this is the same bug or a different one, but jonross@ and I have been hitting this:

C:\src\chromium4\src>gn args out\Debug_gn_component
Waiting for editor on "C:\src\chromium4\src\out\Debug_gn_component\args.gn"...
Generating files...
ERROR at dynamically parsed input that //build/config/win/visual_studio_version.gni:29:7 loaded :2:12: Newline in string constant.
sdk_path = "C:\Program Files (x86)\Windows Kits\10\"
           ^-----------------------------------------

This gets repackaged as sdk_path = "C:\Program Files (x86)\Windows Kits\10\", like this:

> python build\vs_toolchain.py get_toolchain_dir
  vs_path = "C:\Program Files (x86)\Microsoft Visual Studio 14.0"
  sdk_path = "C:\Program Files (x86)\Windows Kits\10\"
  vs_version = "2015"
  wdk_dir = ""
  runtime_dirs = "None"

and the gn parser gets confused (see Tokenizer::AdvanceToEndOfToken) and reports a newline in string constant.

crrev.com/1827663002 is a possible fix.

I meant to say that this only happens when DEPOT_TOOLS_WIN_TOOLCHAIN=0.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12bbca48cda56b2a10a68f8f69bb90906189c4bf

commit 12bbca48cda56b2a10a68f8f69bb90906189c4bf
Author: brucedawson <brucedawson@chromium.org>
Date: Wed Mar 23 00:58:06 2016

Strip trailing backslashes from vcvarsall results

When building with DEPOT_TOOLS_WIN_TOOLCHAIN=0 the vs_toolchain.py
script uses environment variables set up by vcvarsall.bat, such as
WINDOWSSDKDIR. The default value of this with VS 2015 is
WindowsSdkDir=C:\Program Files (x86)\Windows Kits\10\ - note the
trailing slash.

When ninja runs "build\vs_toolchain.py get_toolchain_dir" it translates
this to:

sdk_path = "C:\Program Files (x86)\Windows Kits\10\"

The trailing slash in front of the quote confuses the gn parser. This
change strips those trailing slashes. For more details see the gn
docs:

https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/language.md#Strings

BUG=593154

Review URL: https://codereview.chromium.org/1827663002

Cr-Commit-Position: refs/heads/master@{#382752}

[modify] https://crrev.com/12bbca48cda56b2a10a68f8f69bb90906189c4bf/build/vs_toolchain.py

Any idea whether this is fixed now? If there are no more known reproes then I'm closing this as fixed.

scottmg@, as you still able to repro this issue?

Pretty sure #4 is unrelated to the initial report. The initial one is because get_toolchain_if_necessary prints "Calculating hash of toolchain..." now.

I don't think this blocks the GN migration.

This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot