New issue
Advanced search Search tips

Issue 593143 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Fetching the matching rules when control app is installed

Project Member Reported by rajendrant@chromium.org, Mar 8 2016

Issue description

Matching rules are fetched on every UI navigation after the control app 
is installed. In addition to that rules should be fetched when control
app gets installed as well.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8493756f1647a3f6a0e09d8b75c4c643d7b1ba2b

commit 8493756f1647a3f6a0e09d8b75c4c643d7b1ba2b
Author: rajendrant <rajendrant@chromium.org>
Date: Wed Mar 09 00:55:40 2016

Fetching the matching rules when control app is installed

Matching rules are fetched on every UI navigation after the control app
is installed. In addition to that rules should be fetched when control
app gets installed as well.

BUG= 593143 

Review URL: https://codereview.chromium.org/1774973004

Cr-Commit-Position: refs/heads/master@{#380002}

[modify] https://crrev.com/8493756f1647a3f6a0e09d8b75c4c643d7b1ba2b/chrome/browser/android/data_usage/data_use_tab_model.cc
[modify] https://crrev.com/8493756f1647a3f6a0e09d8b75c4c643d7b1ba2b/chrome/browser/android/data_usage/external_data_use_observer_unittest.cc

Labels: Merge-Request-50
Needed in M-50 for matching rule regexes to be fetched when external control app is installed. Requesting for approval.

Thanks
Raj

Comment 3 by tin...@google.com, Mar 9 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 14 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e8381a203e0e6f345a0d6b19f130239e4aacf2d

commit 4e8381a203e0e6f345a0d6b19f130239e4aacf2d
Author: Tarun Bansal <tbansal@google.com>
Date: Mon Mar 14 21:42:32 2016

Fetching the matching rules when control app is installed

Matching rules are fetched on every UI navigation after the control app
is installed. In addition to that rules should be fetched when control
app gets installed as well.

BUG= 593143 

Review URL: https://codereview.chromium.org/1774973004

Cr-Commit-Position: refs/heads/master@{#380002}
(cherry picked from commit 8493756f1647a3f6a0e09d8b75c4c643d7b1ba2b)

Review URL: https://codereview.chromium.org/1802063002 .

Cr-Commit-Position: refs/branch-heads/2661@{#224}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/4e8381a203e0e6f345a0d6b19f130239e4aacf2d/chrome/browser/android/data_usage/data_use_tab_model.cc
[modify] https://crrev.com/4e8381a203e0e6f345a0d6b19f130239e4aacf2d/chrome/browser/android/data_usage/external_data_use_observer_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment