New issue
Advanced search Search tips

Issue 593128 link

Starred by 1 user
Status: Verified
Owner: ----
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Drop cap letter not handled correctly in DOM Distiller

Project Member Reported by wychen@chromium.org, Mar 8 2016 
Version: M50

What steps will reproduce the problem?
(1) Enable DOM distiller
(2) Distill http://www.nytimes.com/2016/02/28/magazine/what-google-learned-from-its-quest-to-build-the-perfect-team.html

What is the expected output? What do you see instead?
The drop cap letter in the original markup is:

<p class="story-body-text story-content" data-para-count="803" data-total-count="803" itemprop="articleBody" id="story-continues-1"><strong><span class="dropcap">L</span>ike most 25-year-olds,</strong>...

After distillation, it became:

<span class="dropcap">L</span><p class="story-body-text story-content" data-para-count="803" data-total-count="803" itemprop="articleBody" dir="ltr"><strong dir="ltr">ike most 25-year-olds,</strong>...
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04fe15d5c151bd41ad3f757e03977218f78e1828

commit 04fe15d5c151bd41ad3f757e03977218f78e1828
Author: mdjones <mdjones@chromium.org>
Date: Fri Apr 22 22:26:23 2016

Roll DOM Distiller JavaScript distribution package

Diff since last roll:
https://github.com/chromium/dom-distiller/compare/349b932fc2...c3edb386a9

Picked up changes:
c3edb38 Add travis-ci support
adbdbec Fix for Schema.org title extraction.
f40e521 Lazy evaluation of MarkupParsers
84cfcd2 Retain image sizes
3b3253f Make long strings easier to compare in assertion failure
fc19f02 Clean attributes of mRoot between tests properly
ccefff9 Handle drop cap letters
9101ca4 Fix spelling in comments
cfb7588 Update README.md
4d0809f Reformat README.md to Google style
72998ef Add scripts for distillability modeling
7310b0f Process the root element in various DomUtil functions

BUG= 483172 , 552408 , 576553 ,589294, 591143 , 593128 , 604177 ,605484

Review URL: https://codereview.chromium.org/1908173005

Cr-Commit-Position: refs/heads/master@{#389270}

[modify] https://crrev.com/04fe15d5c151bd41ad3f757e03977218f78e1828/DEPS
[modify] https://crrev.com/04fe15d5c151bd41ad3f757e03977218f78e1828/third_party/dom_distiller_js/README.chromium
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 27 2016

Labels: merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b8b020e81c365d23e59da605d022ec539039f26

commit 8b8b020e81c365d23e59da605d022ec539039f26
Author: Matthew Jones <mdjones@chromium.org>
Date: Wed Apr 27 21:53:53 2016

Roll DOM Distiller JavaScript distribution package

Diff since last roll:
https://github.com/chromium/dom-distiller/compare/349b932fc2...c3edb386a9

Picked up changes:
c3edb38 Add travis-ci support
adbdbec Fix for Schema.org title extraction.
f40e521 Lazy evaluation of MarkupParsers
84cfcd2 Retain image sizes
3b3253f Make long strings easier to compare in assertion failure
fc19f02 Clean attributes of mRoot between tests properly
ccefff9 Handle drop cap letters
9101ca4 Fix spelling in comments
cfb7588 Update README.md
4d0809f Reformat README.md to Google style
72998ef Add scripts for distillability modeling
7310b0f Process the root element in various DomUtil functions

BUG= 483172 , 552408 , 576553 ,589294, 591143 , 593128 , 604177 ,605484

Review URL: https://codereview.chromium.org/1908173005

Cr-Commit-Position: refs/heads/master@{#389270}
(cherry picked from commit 04fe15d5c151bd41ad3f757e03977218f78e1828)

Review URL: https://codereview.chromium.org/1923953004 .

Cr-Commit-Position: refs/branch-heads/2704@{#276}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/8b8b020e81c365d23e59da605d022ec539039f26/DEPS
[modify] https://crrev.com/8b8b020e81c365d23e59da605d022ec539039f26/third_party/dom_distiller_js/README.chromium

Comment 3 by ajha@chromium.org, May 4 2016

Labels: TE-Verified-M51 TE-Verified-51.0.2704.36
Verified the fix on the latest M-51(51.0.2704.36) on Windows-7 and this is Working as intended. Attached is the screenshot of the same.
593128.png
341 KB View Download

Comment 4 by wychen@chromium.org, May 4 2016

Status: Verified (was: Untriaged)
►

Sign in to add a comment