New issue
Advanced search Search tips

Issue 593111 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Android] TabStrip swipe order not intuitive when using TalkBack

Reported by kra...@amazon.com, Mar 8 2016

Issue description

Version: Tip of master (51)
OS: Android (reproduced on 5.1.1, 5.0.2, and 4.4.4 (most likely all versions)

What steps will reproduce the problem?
(1) Enable TalkBack
(2) Open Chrome, open three tabs and select the middle one
(3) Swipe left and right

What is the expected output? What do you see instead?
Expected:
Left goes to the tab left of that is selected, right goes to the tab right.
Tab title should be on the left of the close button
Actual:
Tab order is dependent on what tab is selected and thus inconsistent with the UI.
Close button is considered left of the actual Tab.

Please use labels and text to provide additional information.
Don't think I have permission to add labels :(
 
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a4b51b68e4120a2e7008618ab627af94605f515

commit 1a4b51b68e4120a2e7008618ab627af94605f515
Author: kraush <kraush@amazon.com>
Date: Fri Apr 15 15:34:05 2016

Fix accessibility order of Android tabstrip

This change alters the accessibility order of the tabstrip
on Android devices. It contains two changes:
- "Close tab" button will be selected after the tab itself
  during linear navigation
- Tabs are selected from left to right when using linear
  navigation, rather than basing the order on which tab is
  currently active

BUG= 593111 

Review URL: https://codereview.chromium.org/1763713003

Cr-Commit-Position: refs/heads/master@{#387604}

[modify] https://crrev.com/1a4b51b68e4120a2e7008618ab627af94605f515/chrome/android/BUILD.gn
[modify] https://crrev.com/1a4b51b68e4120a2e7008618ab627af94605f515/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java
[modify] https://crrev.com/1a4b51b68e4120a2e7008618ab627af94605f515/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutTab.java
[modify] https://crrev.com/1a4b51b68e4120a2e7008618ab627af94605f515/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[add] https://crrev.com/1a4b51b68e4120a2e7008618ab627af94605f515/chrome/android/junit/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperTest.java
[modify] https://crrev.com/1a4b51b68e4120a2e7008618ab627af94605f515/chrome/chrome_tests.gypi
[modify] https://crrev.com/1a4b51b68e4120a2e7008618ab627af94605f515/ui/android/java/src/org/chromium/ui/base/LocalizationUtils.java

Cc: cbiesin...@chromium.org
Components: UI>Browser>Mobile>TabSwitcher
Can this be marked fixed now?

Comment 4 by kra...@amazon.com, Jul 11 2016

Yes, please go ahead and mark as fixed :)
Status: Fixed (was: Untriaged)
Thanks!

Sign in to add a comment