New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 593091 link

Starred by 2 users
Status: Fixed
Owner:
anthonyvd@chromium.org
Closed: Mar 2016
Cc:
█ apaci...@chromium.org
anthonyvd@chromium.org
█ rnimmagadda@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Can't open new password separated sign in flow on Canary

Project Member Reported by ew...@chromium.org, Mar 8 2016 
Version: Version 51.0.2671.0 canary (64-bit)
OS: Mac

What steps will reproduce the problem?
(1) Sign out of Chrome
(2) Open the user menu
(3) Click "Sign in to Chrome"

Expected:
The new sign in flow should open

Actual:
Nothing happens
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4588b6b41a9356338c1c2a2eea3bf11fb8647a35

commit 4588b6b41a9356338c1c2a2eea3bf11fb8647a35
Author: anthonyvd <anthonyvd@chromium.org>
Date: Thu Mar 17 19:50:07 2016

Fix a regression where the tab-modal signin flow wasn't shown.

https://codereview.chromium.org/1781433002 changed some of the
constrained_window code and updated some callers, but not the tab-modal
signin flow. The modal was being created but not shown.

BUG= 593091 , 217034 

Review URL: https://codereview.chromium.org/1815433002

Cr-Commit-Position: refs/heads/master@{#381778}

[modify] https://crrev.com/4588b6b41a9356338c1c2a2eea3bf11fb8647a35/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.mm

Comment 2 by apaci...@chromium.org, Mar 17 2016

Cc: apaci...@chromium.org anthonyvd@chromium.org
 Issue 595752  has been merged into this issue.

Comment 3 by apaci...@chromium.org, Mar 23 2016

Labels: Merge-Request-50
Status: Fixed (was: Assigned)

Comment 4 by tin...@google.com, Mar 23 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 23 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ef11436d4619a1292803a29f2623df4f2f44bf6

commit 8ef11436d4619a1292803a29f2623df4f2f44bf6
Author: Jennifer Apacible <apacible@google.com>
Date: Wed Mar 23 23:13:36 2016

Fix a regression where the tab-modal signin flow wasn't shown.

https://codereview.chromium.org/1781433002 changed some of the
constrained_window code and updated some callers, but not the tab-modal
signin flow. The modal was being created but not shown.

BUG= 593091 , 217034 

Review URL: https://codereview.chromium.org/1815433002

Cr-Commit-Position: refs/heads/master@{#381778}
(cherry picked from commit 4588b6b41a9356338c1c2a2eea3bf11fb8647a35)

Review URL: https://codereview.chromium.org/1826953002 .

Cr-Commit-Position: refs/branch-heads/2661@{#370}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/8ef11436d4619a1292803a29f2623df4f2f44bf6/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.mm

Comment 6 by rnimmagadda@chromium.org, Mar 30 2016

Cc: rnimmagadda@chromium.org
Labels: TE-Verified-M50 TE-Verified-50.0.2661.57
Verified the fix on MAC (10.11.3) for Google Chrome Beta Version - 50.0.2661.57

Screen-recording is attached.

Added TE-Verified label.
593091.mov
6.2 MB Download
►

Sign in to add a comment