New issue
Advanced search Search tips

Issue 593086 link

Starred by 1 user
Status: Verified
Owner:
llozano@chromium.org
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

AFDO: make sure profile collection does not run for too long

Project Member Reported by llozano@chromium.org, Mar 8 2016 
In the current AFDO process, one of the telemetry benchmarks used could erroneously execute for much longer than intended. This causes problems (firing of timeouts) in the PFQ builder. We need to modify the AFDO profile collection step to run for a limited amount of time independently of the failures that may happen.
For context see chromium:589905
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9162c55fe4568d1ef42d1f5e5f57484285038c14

commit 9162c55fe4568d1ef42d1f5e5f57484285038c14
Author: Luis Lozano <llozano@chromium.org>
Date: Wed Mar 09 21:11:09 2016

AFDO: reduce time for profile collection

Profile collection is taking longer since when this process was started.
This may cause timeout problems in the PFQ builder especially when
benchmarks are retried. This may also be the cause for a weird
linux "perf" failure where it runs out-of-memory at the end of the
profile collection. To ameliorate these problems, I am reducing
the number of iterations for the benchmark that takes the longest time.

BUG= chromium:593086 
BUG= chromium:581488 
TEST=executed by hand. verified time is reduced.

Change-Id: I70824d0ca47da6d77bd2018e4208681bb2a25fa7
Reviewed-on: https://chromium-review.googlesource.com/331833
Commit-Ready: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>

[modify] https://crrev.com/9162c55fe4568d1ef42d1f5e5f57484285038c14/server/site_tests/telemetry_AFDOGenerate/telemetry_AFDOGenerate.py

Comment 2 by llozano@chromium.org, Sep 25 2017

Status: Verified (was: Assigned)
closing this for now. We are not going to take further action on this since things are working fine now.
►

Sign in to add a comment