third_party/WebKit path is hardcoded in trybot_command.py |
|||||
Issue description
Traceback (most recent call last):
<module> at tools/perf/run_benchmark:22
sys.exit(main())
main at tools/perf/run_benchmark:19
return benchmark_runner.main(config, [trybot_command.Trybot])
main at third_party/catapult/telemetry/telemetry/benchmark_runner.py:419
return command_instance.Run(options, args)
Run at tools/perf/core/trybot_command.py:203
os.chdir('third_party/WebKit/')
OSError: [Errno 2] No such file or directory: 'third_party/WebKit/'
,
Mar 8 2016
,
Mar 8 2016
Core bug here is actually that trybot_command checks for Blink changes at all, which is functionality that we should be able to safely remove now that the Blink merge is well behind us.
,
Mar 8 2016
Agreed this functionality should be removed. prasadv: we just talked about v8 perf tryjobs; would it need something like this to run from telemetry?
,
Mar 8 2016
Yes, I think so. I'm looking into it.
,
Mar 8 2016
Ethan, the change will be to remove this branch, right? https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/core/trybot_command.py&l=222
,
Mar 8 2016
Quinten, yes, see https://codereview.chromium.org/1780453002
,
Mar 16 2016
Ethan, I think the change https://codereview.chromium.org/1780453002 didn't land yet?
,
Mar 17 2016
That's correct; last time I tried to land it the tree was closed and it just slipped through. I'll make one last modification and tick the box today.
,
Feb 3 2017
,
Jul 5 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by eakuefner@chromium.org
, Mar 8 2016