New issue
Advanced search Search tips

Issue 593074 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

//components/cronet/android:generate_javadoc Fails due to warnings

Project Member Reported by agrieve@chromium.org, Mar 8 2016

Issue description

gn gen --args='target_os="android"' out/Debug
ninja -C out/Debug components/cronet/android:generate_javadoc

Fails with:
  [javadoc] /usr/local/google/home/agrieve/ssd/git/infra_internal/build/slave/fake_slave/build/src/components/cronet/android/api/src/org/chromium/net/UploadDataProviders.java:24: warning
: no @return
  [javadoc]     public static UploadDataProvider create(final File file) {
  [javadoc]                                      ^
  [javadoc] /usr/local/google/home/agrieve/ssd/git/infra_internal/build/slave/fake_slave/build/src/components/cronet/android/api/src/org/chromium/net/UploadDataProviders.java:39: warning: no @return
  [javadoc]     public static UploadDataProvider create(final ParcelFileDescriptor fd) {
  [javadoc]                                      ^
  [javadoc] /usr/local/google/home/agrieve/ssd/git/infra_internal/build/slave/fake_slave/build/src/components/cronet/android/api/src/org/chromium/net/UploadDataProviders.java:56: warning: no @param for buffer
  [javadoc]     public static UploadDataProvider create(ByteBuffer buffer) {
  [javadoc]                                      ^
  [javadoc] /usr/local/google/home/agrieve/ssd/git/infra_internal/build/slave/fake_slave/build/src/components/cronet/android/api/src/org/chromium/net/UploadDataProviders.java:56: warning: no @return
  [javadoc]     public static UploadDataProvider create(ByteBuffer buffer) {
  [javadoc]                                      ^
  [javadoc] /usr/local/google/home/agrieve/ssd/git/infra_internal/build/slave/fake_slave/build/src/components/cronet/android/api/src/org/chromium/net/UploadDataProviders.java:61: warning: no @param for data
  [javadoc]     public static UploadDataProvider create(byte[] data, int offset, int length) {
  [javadoc]                                      ^
  [javadoc] /usr/local/google/home/agrieve/ssd/git/infra_internal/build/slave/fake_slave/build/src/components/cronet/android/api/src/org/chromium/net/UploadDataProviders.java:61: warning: no @param for offset
  [javadoc]     public static UploadDataProvider create(byte[] data, int offset, int length) {
  [javadoc]                                      ^
  [javadoc] /usr/local/google/home/agrieve/ssd/git/infra_internal/build/slave/fake_slave/build/src/components/cronet/android/api/src/org/chromium/net/UploadDataProviders.java:61: warning: no @param for length
  [javadoc]     public static UploadDataProvider create(byte[] data, int offset, int length) {
  [javadoc]                                      ^
  [javadoc] /usr/local/google/home/agrieve/ssd/git/infra_internal/build/slave/fake_slave/build/src/components/cronet/android/api/src/org/chromium/net/UploadDataProviders.java:61: warning: no @return
  [javadoc]     public static UploadDataProvider create(byte[] data, int offset, int length) {
  [javadoc]                                      ^
  [javadoc] /usr/local/google/home/agrieve/ssd/git/infra_internal/build/slave/fake_slave/build/src/components/cronet/android/api/src/org/chromium/net/UploadDataProviders.java:66: warning: no @param for data
  [javadoc]     public static UploadDataProvider create(byte[] data) {
  [javadoc]                                      ^
  [javadoc] /usr/local/google/home/agrieve/ssd/git/infra_internal/build/slave/fake_slave/build/src/components/cronet/android/api/src/org/chromium/net/UploadDataProviders.java:66: warning: no @return
  [javadoc]     public static UploadDataProvider create(byte[] data) {
  [javadoc]                                      ^
  [javadoc] Building index for all the packages and classes...
  [javadoc] Building index for all classes...
  [javadoc] Generating /usr/local/google/home/agrieve/ssd/git/infra_internal/build/slave/fake_slave/build/src/out/Release/cronet/javadoc/overview-summary.html...
  [javadoc] 10 warnings

BUILD SUCCESSFUL
Total time: 2 seconds

ninja: build stopped: subcommand failed.

 

Comment 1 by mef@chromium.org, Mar 8 2016

Components: Internals>Network>Library
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fce3e9aac221b10ef4a9f3f7aefa5d7a0d79abf2

commit fce3e9aac221b10ef4a9f3f7aefa5d7a0d79abf2
Author: agrieve <agrieve@chromium.org>
Date: Tue Mar 08 23:54:49 2016

Fix javadoc warnings in cronet's UploadDataProviders.java

BUG= 593074 

Review URL: https://codereview.chromium.org/1773123003

Cr-Commit-Position: refs/heads/master@{#379979}

[modify] https://crrev.com/fce3e9aac221b10ef4a9f3f7aefa5d7a0d79abf2/components/cronet/android/api/src/org/chromium/net/UploadDataProviders.java

Status: Fixed (was: Started)

Sign in to add a comment