New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 593068 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit 15 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Remove all remnants of the Data Reduction Proxy SSL experiment

Project Member Reported by bengr@chromium.org, Mar 8 2016

Issue description

Chrome used to support an experiment to tunnel TLS traffic through the Data Reduction Proxy using HTTP CONNECT. The experiment is over and this code is not needed anymore. All remaining code related to that experiment should be removed. For example, https://code.google.com/p/chromium/codesearch#chromium/src/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPreferences.java&l=50



 

Comment 1 by bengr@chromium.org, Mar 8 2016

Cc: dfalcant...@chromium.org

Comment 2 by bengr@chromium.org, Mar 18 2016

Labels: -Pri-3 M-51 Pri-2
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/2484d444f3125d8b11a50b6a14ebbff7a4a382e1

commit 2484d444f3125d8b11a50b6a14ebbff7a4a382e1
Author: Megan Jablonski <megjablon@google.com>
Date: Wed Mar 30 18:29:14 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd4c6ac99e771e0d5893b25d8058d3153efb6fa1

commit bd4c6ac99e771e0d5893b25d8058d3153efb6fa1
Author: megjablon <megjablon@chromium.org>
Date: Fri Apr 01 23:56:50 2016

Remove the Data Reduction Proxy SSL Android code

The SSL experiment is over so remove the SSL snackbar and preferences
code.

BUG= 593068 

Review URL: https://codereview.chromium.org/1849613002

Cr-Commit-Position: refs/heads/master@{#384732}

[modify] https://crrev.com/bd4c6ac99e771e0d5893b25d8058d3153efb6fa1/chrome/android/java/res/xml/data_reduction_preferences_off.xml
[modify] https://crrev.com/bd4c6ac99e771e0d5893b25d8058d3153efb6fa1/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/bd4c6ac99e771e0d5893b25d8058d3153efb6fa1/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java
[modify] https://crrev.com/bd4c6ac99e771e0d5893b25d8058d3153efb6fa1/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java
[modify] https://crrev.com/bd4c6ac99e771e0d5893b25d8058d3153efb6fa1/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPreferences.java
[modify] https://crrev.com/bd4c6ac99e771e0d5893b25d8058d3153efb6fa1/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/bd4c6ac99e771e0d5893b25d8058d3153efb6fa1/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc
[modify] https://crrev.com/bd4c6ac99e771e0d5893b25d8058d3153efb6fa1/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.h

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/842e143a1a344bc4865d7ae85a300d0dba45a267

commit 842e143a1a344bc4865d7ae85a300d0dba45a267
Author: megjablon <megjablon@chromium.org>
Date: Thu Apr 14 00:08:30 2016

Remove the Data Reduction Proxy TLS experiment code

Chrome used to support an experiment to tunnel TLS traffic
through the Data Reduction Proxy using HTTP CONNECT. The
experiment is over so this code is no longer needed.

BUG= 593068 

Review URL: https://codereview.chromium.org/1871783002

Cr-Commit-Position: refs/heads/master@{#387162}

[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.h
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.h
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_test_utils.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_test_utils.h
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.h
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/common/data_reduction_proxy_config_values.h
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.h
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.h
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.h
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc
[modify] https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267/components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h

Project Member

Comment 7 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8deb20c51c1ba007fee2929c07e9c11ac8d171a1

commit 8deb20c51c1ba007fee2929c07e9c11ac8d171a1
Author: megjablon <megjablon@chromium.org>
Date: Fri May 20 22:24:34 2016

Remove unused DataReductionProxyInfoBar and related code

BUG= 593068 

Review-Url: https://codereview.chromium.org/2000433002
Cr-Commit-Position: refs/heads/master@{#395184}

[delete] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java
[delete] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java
[modify] https://crrev.com/8deb20c51c1ba007fee2929c07e9c11ac8d171a1/chrome/android/java_sources.gni
[modify] https://crrev.com/8deb20c51c1ba007fee2929c07e9c11ac8d171a1/chrome/browser/android/chrome_jni_registrar.cc
[delete] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate_android.cc
[delete] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate_android.h
[delete] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc
[delete] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h
[modify] https://crrev.com/8deb20c51c1ba007fee2929c07e9c11ac8d171a1/chrome/chrome_browser.gypi
[modify] https://crrev.com/8deb20c51c1ba007fee2929c07e9c11ac8d171a1/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/8deb20c51c1ba007fee2929c07e9c11ac8d171a1/components/infobars/core/infobar_delegate.h
[modify] https://crrev.com/8deb20c51c1ba007fee2929c07e9c11ac8d171a1/tools/metrics/histograms/histograms.xml

Sign in to add a comment