New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 593037 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Benchmarks need the ability to be disabled per device type.

Project Member Reported by simonhatch@chromium.org, Mar 8 2016

Issue description

Not sure how this should look, but it would be helpful in cases where the test is failing on one device type.

@disabled("nexus5x") ?
 
Cc: aiolos@chromium.org
I worry that adding this functionality to decorators will be brittle.

You can always define a ShouldDisable method, which takes a possible_browser. I'm kind of thinking that maybe the thing we should do here is simply expose GetProp through android_platform, for this kind of tools/perf-side wrangling.
Owner: eakuefner@chromium.org
Status: Assigned (was: Untriaged)
Chatted offline with Ned and Kari; actually we can add this to decorators using GetDeviceType. I'll investigate this later.
Status: WontFix (was: Assigned)

Sign in to add a comment