New issue
Advanced search Search tips

Issue 593034 link

Starred by 1 user
Status: Fixed
Owner:
dvadym@chromium.org
Closed: Mar 2016
Cc:
engedy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

The update password bubble reuses the save string

Project Member Reported by vasi...@chromium.org, Mar 8 2016 
Version: 51
OS: all

What steps will reproduce the problem?
(1) Save a password for an Android app
(2) Login with Chrome using a new password

What is the expected output? What do you see instead?
The update bubble appears but it proposes to save the password. In cases we can't say "Update password for THIS site?" the bubble falls back to the save string which is confusing.
Screen Shot 2016-03-02 at 9.55.36 PM.png
55.8 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a9874f00efac95d9b4b21ff17ef415c0b0d8f0a

commit 4a9874f00efac95d9b4b21ff17ef415c0b0d8f0a
Author: dvadym <dvadym@chromium.org>
Date: Fri Mar 11 16:17:36 2016

Password update bubble UI improvement.

When current domain and domain of saved credentials don't coincide then show update password bubbletitle as "Do you want to update password for <domain>?" instead of "Do you want to save password for <domain>?".

BUG= 593034 

Review URL: https://codereview.chromium.org/1787653002

Cr-Commit-Position: refs/heads/master@{#380646}

[modify] https://crrev.com/4a9874f00efac95d9b4b21ff17ef415c0b0d8f0a/chrome/app/generated_resources.grd
[modify] https://crrev.com/4a9874f00efac95d9b4b21ff17ef415c0b0d8f0a/chrome/browser/ui/passwords/manage_passwords_view_utils.cc
[modify] https://crrev.com/4a9874f00efac95d9b4b21ff17ef415c0b0d8f0a/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc

Comment 2 by dvadym@chromium.org, Mar 16 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment