uniform buffer block data loaded wrong
Reported by
shreks...@gmail.com,
Mar 8 2016
|
||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2670.0 Safari/537.36 Example URL: Steps to reproduce the problem: 1. https://github.com/WebGLSamples/WebGL2Samples/blob/16a1a9818d3314b4c42332b4863fe8fea67c346f/samples/buffer_uniform.html 2. copy the html content to a html file 3. open the html file with WebGL 2 enabled (--enable-unsafe-es3-apis) Chrome Canary What is the expected behavior? There should be a colorful rectangle showing up. This is working correctly on Mac. The expected result can be found here: https://github.com/WebGLSamples/WebGL2Samples/issues/14#issuecomment-193388173 What went wrong? Seems that when calling "vec4 pEC = u_perDraw.transform.MV * vec4(position, 1.0);" in glsl, the `u_perDraw.transform.MV` from a ubo doesn't have the correct data. The expected result screen shot can be found here: https://github.com/WebGLSamples/WebGL2Samples/issues/14#issuecomment-193388173 Does it occur on multiple sites: N/A Is it a problem with a plugin? N/A Did this work before? N/A Does this work in other browsers? No Firefox Developer Edition 46.0a2 (2016-02-29) , Windows 10 Chrome version: 51.0.2670.0 Channel: canary OS Version: 10.0 Flash Version: Shockwave Flash 21.0 r0
,
Mar 10 2016
Able to reproduce this on the latest stable(49.0.2623.87) and the latest canary(51.0.2673.0) on Windows-7. Assigning to kbr@ for further help in investigating this further.
,
Mar 10 2016
,
Mar 10 2016
If this is working on Mac OS then there might be a bug in ANGLE's uniform buffer implementation.
,
Mar 10 2016
Just tested the file that kbr@ posted on my Windows workstation with 51.0.2673.0 (Official Build) canary (64-bit) using an NVIDIA chipset (GTX970). Appears to be working fine.
,
Mar 10 2016
Sorry, we can't reproduce the problem reported here. Please provide a screenshot of the failure mode.
,
Mar 10 2016
It's nothing but black with my Windows 10 laptop Nvidia GTX970M and 51.0.2673.0 canary (64-bit). Might be a driver issue or something external. Thanks for the feedback.
,
Mar 10 2016
@shrekshao: please copy/paste about:gpu from your system.
,
Mar 10 2016
This is from canary:
Graphics Feature Status
Canvas: Hardware accelerated
Flash: Hardware accelerated
Flash Stage3D: Hardware accelerated
Flash Stage3D Baseline profile: Hardware accelerated
Compositing: Hardware accelerated
Multiple Raster Threads: Enabled
Native GpuMemoryBuffers: Software only. Hardware acceleration disabled
Rasterization: Software only. Hardware acceleration disabled
Video Decode: Hardware accelerated
Video Encode: Hardware accelerated
WebGL: Hardware accelerated
Driver Bug Workarounds
clear_uniforms_before_first_program_use
disable_discard_framebuffer
disable_msaa_on_non_webgl_contexts
exit_on_context_lost
force_cube_complete
scalarize_vec_and_mat_constructor_args
texsubimage_faster_than_teximage
Problems Detected
Some drivers are unable to reset the D3D device in the GPU process sandbox
Applied Workarounds: exit_on_context_lost
TexSubImage is faster for full uploads on ANGLE
Applied Workarounds: texsubimage_faster_than_teximage
Clear uniforms before first program use on all platforms: 124764, 349137
Applied Workarounds: clear_uniforms_before_first_program_use
Always rewrite vec/mat constructors to be consistent: 398694
Applied Workarounds: scalarize_vec_and_mat_constructor_args
ANGLE crash on glReadPixels from incomplete cube map texture: 518889
Applied Workarounds: force_cube_complete
On Intel GPUs MSAA performance is not acceptable for GPU rasterization: 527565
Applied Workarounds: disable_msaa_on_non_webgl_contexts
Framebuffer discarding can hurt performance on non-tilers: 570897
Applied Workarounds: disable_discard_framebuffer
Accelerated rasterization has been disabled, either via about:flags or command line.
Disabled Features: rasterization
Native GpuMemoryBuffers have been disabled, either via about:flags or command line.
Disabled Features: native_gpu_memory_buffers
Version Information
Data exported 2016/3/10 下午6:58:51
Chrome version Chrome/51.0.2673.0
Operating system Windows NT 10.0
Software rendering list version 10.18
Driver bug list version 8.47
ANGLE commit id b5abec33708f
2D graphics backend Skia
Command Line Args SxS\Application\chrome.exe" --enable-unsafe-es3-apis --flag-switches-begin --flag-switches-end
Driver Information
Initialization time 16
In-process GPU false
Sandboxed false
GPU0 VENDOR = 0x8086, DEVICE= 0x0416
Optimus false
AMD switchable false
DisplayLink Version 7.9.630.0
Desktop compositing Aero Glass
Diagonal Monitor Size of \\.\DISPLAY1 17.2"
Driver vendor Intel Corporation
Driver version 20.19.15.4331
Driver date 11-18-2015
Pixel shader version 5.0
Vertex shader version 5.0
Max. MSAA samples 8
Machine model name
Machine model version
GL_VENDOR Google Inc.
GL_RENDERER ANGLE (Intel(R) HD Graphics 4600 Direct3D11 vs_5_0 ps_5_0)
GL_VERSION OpenGL ES 3.0 (ANGLE 2.1.0.b5abec33708f)
GL_EXTENSIONS GL_OES_element_index_uint GL_OES_packed_depth_stencil GL_OES_get_program_binary GL_OES_rgb8_rgba8 GL_EXT_texture_format_BGRA8888 GL_EXT_read_format_bgra GL_NV_pixel_buffer_object GL_OES_mapbuffer GL_EXT_map_buffer_range GL_EXT_color_buffer_half_float GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_float GL_OES_texture_float_linear GL_EXT_texture_rg GL_EXT_texture_compression_dxt1 GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_OES_compressed_ETC1_RGB8_texture GL_EXT_sRGB GL_ANGLE_depth_texture GL_OES_depth32 GL_EXT_texture_storage GL_OES_texture_npot GL_EXT_draw_buffers GL_EXT_texture_filter_anisotropic GL_EXT_occlusion_query_boolean GL_NV_fence GL_EXT_disjoint_timer_query GL_EXT_robustness GL_EXT_blend_minmax GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_pack_reverse_row_order GL_OES_standard_derivatives GL_EXT_shader_texture_lod GL_EXT_frag_depth GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_EXT_discard_framebuffer GL_EXT_debug_marker GL_OES_EGL_image GL_EXT_unpack_subimage GL_NV_pack_subimage GL_EXT_color_buffer_float GL_OES_vertex_array_object GL_KHR_debug GL_ANGLE_lossy_etc_decode
Disabled Extensions
Window system binding vendor Google Inc. (adapter LUID: 0000000000010ef0)
Window system binding version 1.4 (ANGLE 2.1.0.b5abec33708f)
Window system binding extensions EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_ANGLE_flexible_surface_compatibility
Direct rendering Yes
Reset notification strategy 0x8252
GPU process crash count 0
Compositor Information
Tile Update Mode One-copy
Partial Raster Enabled
GpuMemoryBuffers Status
ATC Software only
ATCIA Software only
DXT1 Software only
DXT5 Software only
ETC1 Software only
R_8 Software only
RGBA_4444 Software only
RGBX_8888 Software only
RGBA_8888 Software only
BGRX_8888 Software only
BGRA_8888 Software only
YUV_420 Software only
YUV_420_BIPLANAR Software only
UYVY_422 Software only
Diagnostics
0
b3DAccelerationEnabled true
b3DAccelerationExists true
bAGPEnabled true
bAGPExistenceValid true
bAGPExists true
bCanRenderWindow true
bDDAccelerationEnabled true
bDriverBeta false
bDriverDebug false
bDriverSigned false
bDriverSignedValid false
bNoHardware false
dwBpp 32
dwDDIVersion 12
dwHeight 1080
dwRefreshRate 60
dwWHQLLevel 0
dwWidth 1920
iAdapter 0
lDriverSize 35016296
lMiniVddSize 0
szAGPStatusEnglish Enabled
szAGPStatusLocalized Enabled
szChipType Intel(R) HD Graphics Family
szD3DStatusEnglish Enabled
szD3DStatusLocalized Enabled
szDACType Internal
szDDIVersionEnglish 12
szDDIVersionLocalized 12
szDDStatusEnglish Enabled
szDDStatusLocalized Enabled
szDXVAHDEnglish Supported
szDXVAModes ModeMPEG2_A ModeMPEG2_C ModeWMV9_C ModeVC1_C
szDescription Intel(R) HD Graphics 4600
szDeviceId 0x0416
szDeviceIdentifier {D7B78E66-4756-11CF-7363-8726BAC2D935}
szDeviceName \\.\DISPLAY1
szDisplayMemoryEnglish 8247 MB
szDisplayMemoryLocalized 8247 MB
szDisplayModeEnglish 1920 x 1080 (32 bit) (60Hz)
szDisplayModeLocalized 1920 x 1080 (32 bit) (60Hz)
szDriverAssemblyVersion 20.19.15.4331
szDriverAttributes Final Retail
szDriverDateEnglish 2015/11/18 0:00:00
szDriverDateLocalized 11/18/2015 00:00:00
szDriverLanguageEnglish English
szDriverLanguageLocalized English
szDriverModelEnglish WDDM 2.0
szDriverModelLocalized WDDM 2.0
szDriverName igdumdim64.dll,igd10iumd64.dll,igd10iumd64.dll,igd12umd64.dll,igdumdim32,igd10iumd32,igd10iumd32,igd12umd32
szDriverNodeStrongName oem29.inf:5f63e534dd929195:iHSWM_w10:20.19.15.4331:pci\ven_8086&dev_0416
szDriverSignDate
szDriverVersion 20.19.0015.4331
szKeyDeviceID Enum\PCI\VEN_8086&DEV_0416&SUBSYS_06881028&REV_06
szKeyDeviceKey \Registry\Machine\System\CurrentControlSet\Control\Video\{928FE0B8-37B3-4B74-93F8-2F6B9CC6A313}\0000
szManufacturer Intel Corporation
szMiniVdd n/a
szMiniVddDateEnglish n/a
szMiniVddDateLocalized n/a
szMonitorMaxRes
szMonitorName Generic PnP Monitor
szNotesEnglish No problems found.
szNotesLocalized No problems found.
szOverlayEnglish Supported
szRankOfInstalledDriver 00D12001
szRegHelpText
szRevision
szRevisionId 0x0006
szSubSysId 0x06881028
szTestResultD3D7English Not run
szTestResultD3D7Localized Not run
szTestResultD3D8English Not run
szTestResultD3D8Localized Not run
szTestResultD3D9English Not run
szTestResultD3D9Localized Not run
szTestResultDDEnglish Not run
szTestResultDDLocalized Not run
szVdd n/a
szVendorId 0x8086
Log Messages
GpuProcessHostUIShim: The GPU process exited normally. Everything is okay.
,
Mar 14 2016
@shrekshao: I don't know whether your laptop has both Intel and NVIDIA GPUs, but the following indicate it is an Intel GPU: GPU0 VENDOR = 0x8086, DEVICE= 0x0416 GL_RENDERER ANGLE (Intel(R) HD Graphics 4600 Direct3D11 vs_5_0 ps_5_0) Perhaps Chrome isn't detecting this properly. Regardless, we don't have any laptops with recent Intel GPUs on which to test locally -- Geoff, Jamie, do you and can you reproduce?
,
Mar 14 2016
Jamie, thanks for testing! You've got the exact same GPU Shrek does but GL_RENDERER is reported differently. It looks like he's using a newer driver: 20.19.15.4331 from 11-18-2015, rather than 10.18.10.3412 from 1-29-2014. Is there any chance you could try updating?
,
Mar 14 2016
"Updated" the driver, and can now reproduce. about:gpu attached, where my GPU is now listed as a 4600. Not sure what driver I was using before. Of note I had to follow some specific instructions to upgrade the driver. See: https://steamcommunity.com/app/233250/discussions/2/558749190911446231/
,
Mar 14 2016
It's also worth noting that ANGLE currently skips all of its end2end_tests for Uniform Buffers on Intel. https://chromium.googlesource.com/angle/angle.git/+/master/src/tests/gl_tests/UniformBufferTest.cpp#78
,
Mar 14 2016
Jamie: thanks for figuring out how to reproduce this. Olli: could you please report this bug to the Direct3D driver team?
,
Mar 14 2016
Oh jeez, sorry, very tired today. Will email Intel folks.
,
Aug 9 2016
,
Sep 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/296398571213608b99d12266d0ba218f99c87abf commit 296398571213608b99d12266d0ba218f99c87abf Author: Jamie Madill <jmadill@chromium.org> Date: Fri Sep 02 19:00:09 2016 D3D11: Work around Intel uniform buffers bug. When copying from a staging buffer to a uniform buffer, the first upload would be incorrect. Work around this by trying to upload directly to a uniform buffer on the first BufferSubData call. BUG= chromium:593024 Change-Id: I0df3a1422b962bf3ece5d445f435df01e3544b67 Reviewed-on: https://chromium-review.googlesource.com/368774 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/libANGLE/renderer/vulkan/BufferVk.h [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/libANGLE/renderer/vulkan/BufferVk.cpp [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/libANGLE/renderer/gl/BufferGL.cpp [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/libANGLE/renderer/d3d/d3d9/Buffer9.h [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/libANGLE/renderer/d3d/d3d11/Buffer11.cpp [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/libANGLE/renderer/d3d/d3d11/Buffer11.h [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/libANGLE/validationES.cpp [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/libANGLE/renderer/BufferImpl_mock.h [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/tests/gl_tests/UniformBufferTest.cpp [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/tests/gl_tests/D3D11EmulatedIndexedBufferTest.cpp [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/libANGLE/renderer/gl/BufferGL.h [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/libANGLE/Buffer.cpp [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/libANGLE/validationES2.h [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/libANGLE/renderer/BufferImpl.h [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/tests/perf_tests/IndexDataManagerTest.cpp [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/libANGLE/renderer/d3d/d3d9/Buffer9.cpp [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/libANGLE/validationES.h [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/libANGLE/Context.cpp [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/libGLESv2/entry_points_gles_2_0.cpp [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/libANGLE/Buffer.h [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/libANGLE/validationES2.cpp [modify] https://crrev.com/296398571213608b99d12266d0ba218f99c87abf/src/libANGLE/Context.h
,
Sep 6 2016
Some removed suppressions removed in the commit above were still needed, they are added back in a CL that is in the CQ. See https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28New%20Intel%29/builds/1446 for a first failing build.
,
Sep 6 2016
OK, thanks. That's annoying - it's because I was testing on Windows 10 and there's different behaviour in Windows 7.
,
Sep 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/3af2b3b05043de498a193626965d9fb6941e3246 commit 3af2b3b05043de498a193626965d9fb6941e3246 Author: Corentin Wallez <cwallez@chromium.org> Date: Tue Sep 06 13:47:56 2016 UniformBufferTest: add back suppressions for failing tests 296398571213608b99d12266d0ba218f99c87abf fixes most but not all UniformBuffer Wintel failures of the waterfall, add back suppressions needed to make the waterfall green. BUG= chromium:593024 Change-Id: I124666853e9943bcb71083e5563d02e65551f916 Reviewed-on: https://chromium-review.googlesource.com/381451 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> [modify] https://crrev.com/3af2b3b05043de498a193626965d9fb6941e3246/src/tests/gl_tests/UniformBufferTest.cpp
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9bb4e60b43e03ec97398628839dab490c41170d1 commit 9bb4e60b43e03ec97398628839dab490c41170d1 Author: jmadill <jmadill@chromium.org> Date: Wed Sep 07 02:35:51 2016 Roll ANGLE a4e6f07..5a7e20e https://chromium.googlesource.com/angle/angle.git/+log/a4e6f07..5a7e20e BUG= chromium:643075 , chromium:642227 , chromium:638323 , chromium:644057 , 351528 , chromium:593024 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2312243003 Cr-Commit-Position: refs/heads/master@{#416828} [modify] https://crrev.com/9bb4e60b43e03ec97398628839dab490c41170d1/DEPS
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea43c322211a60280a17f5d0a4874ac0c49573e7 commit ea43c322211a60280a17f5d0a4874ac0c49573e7 Author: qiankun.miao <qiankun.miao@intel.com> Date: Wed Sep 07 06:07:57 2016 Update WebGL 2 conformance expectations BUG= 644057 , 593024 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2312373003 Cr-Commit-Position: refs/heads/master@{#416858} [modify] https://crrev.com/ea43c322211a60280a17f5d0a4874ac0c49573e7/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d5d236629766d7b495bedf2b79d3e9066027053 commit 8d5d236629766d7b495bedf2b79d3e9066027053 Author: cwallez <cwallez@chromium.org> Date: Wed Sep 07 16:16:13 2016 WebGL CTS: add back suppressions for UBO tests failing on Win7 Intel BUG= 593024 TBR=zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2319113002 Cr-Commit-Position: refs/heads/master@{#416952} [modify] https://crrev.com/8d5d236629766d7b495bedf2b79d3e9066027053/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9859aac71e6b077f66c37da16896971a81c02e08 commit 9859aac71e6b077f66c37da16896971a81c02e08 Author: jmadill <jmadill@chromium.org> Date: Thu Oct 06 20:11:14 2016 Roll ANGLE d08f3b3..873d00f https://chromium.googlesource.com/angle/angle.git/+log/d08f3b3..873d00f BUG= chromium:653274 , chromium:651493 , chromium:653276 , chromium:593024 , chromium:634525 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2399933002 Cr-Commit-Position: refs/heads/master@{#423643} [modify] https://crrev.com/9859aac71e6b077f66c37da16896971a81c02e08/DEPS
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9859aac71e6b077f66c37da16896971a81c02e08 commit 9859aac71e6b077f66c37da16896971a81c02e08 Author: jmadill <jmadill@chromium.org> Date: Thu Oct 06 20:11:14 2016 Roll ANGLE d08f3b3..873d00f https://chromium.googlesource.com/angle/angle.git/+log/d08f3b3..873d00f BUG= chromium:653274 , chromium:651493 , chromium:653276 , chromium:593024 , chromium:634525 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2399933002 Cr-Commit-Position: refs/heads/master@{#423643} [modify] https://crrev.com/9859aac71e6b077f66c37da16896971a81c02e08/DEPS
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 16 2016
Working on finishing my workaround support for Windows 7 now. Going to block WebGL 2 on this, as it's pretty important for a large population of users.
,
Nov 16 2016
Thanks Jamie!
,
Nov 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/3ae1461355b71c4e16aa7587d65913befe3ad35b commit 3ae1461355b71c4e16aa7587d65913befe3ad35b Author: Jamie Madill <jmadill@chromium.org> Date: Wed Nov 16 19:18:44 2016 Buffer11: Refactor constant buffer range getter. This getter will now return the offset to bind along with the ID3D11Buffer pointer. This encapsulates the logic of the emulation so that we only actually check the capabilities of the driver in a single place. This solves the issue of needing to edit the code in multiple places when trying to force the caps for debugging, and also encapsulates the offset calculation in the Buffer11 class. BUG= chromium:593024 Change-Id: Idb09d560868ae12b98bcaf4ea031c4e0b6c82b4a Reviewed-on: https://chromium-review.googlesource.com/411918 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/3ae1461355b71c4e16aa7587d65913befe3ad35b/src/libANGLE/renderer/d3d/d3d11/Renderer11.cpp [modify] https://crrev.com/3ae1461355b71c4e16aa7587d65913befe3ad35b/src/libANGLE/renderer/d3d/d3d11/Buffer11.cpp [modify] https://crrev.com/3ae1461355b71c4e16aa7587d65913befe3ad35b/src/libANGLE/renderer/d3d/d3d11/Buffer11.h
,
Nov 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/96ed3527d001f77aab86e2128d0669554edeb2d4 commit 96ed3527d001f77aab86e2128d0669554edeb2d4 Author: Jamie Madill <jmadill@chromium.org> Date: Wed Nov 16 19:27:43 2016 Buffer11: Slight cleanup in copyFromStorage. We can call setData internally to re-use the same code. BUG= chromium:593024 Change-Id: I9f53bef1e86a11fc23799123937c354bf45de014 Reviewed-on: https://chromium-review.googlesource.com/411919 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/96ed3527d001f77aab86e2128d0669554edeb2d4/src/libANGLE/renderer/d3d/d3d11/Buffer11.cpp
,
Nov 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/555009cefe4c8706b0f6305bd320b4254b40e4ee commit 555009cefe4c8706b0f6305bd320b4254b40e4ee Author: Jamie Madill <jmadill@chromium.org> Date: Wed Nov 16 19:51:01 2016 Buffer11: Intel workaround for constant buffers. This workaround avoids using inter-buffer copies involving constant buffers. Instead of copying from a staging storage to a constant buffer (or vice-versa), the Buffer memory managment will keep the system memory storage around permanently. This uses a bit more memory but should fix all the problematic cases where we have the canonical version of the buffer data inside GPU memory. BUG= chromium:593024 Change-Id: I2ce0cfd22784aa43e819ce2df2d0da540d0a0cfe Reviewed-on: https://chromium-review.googlesource.com/412140 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/555009cefe4c8706b0f6305bd320b4254b40e4ee/src/libANGLE/renderer/d3d/d3d11/renderer11_utils.cpp [modify] https://crrev.com/555009cefe4c8706b0f6305bd320b4254b40e4ee/src/libANGLE/renderer/d3d/d3d11/Buffer11.cpp [modify] https://crrev.com/555009cefe4c8706b0f6305bd320b4254b40e4ee/src/libANGLE/renderer/d3d/WorkaroundsD3D.h [modify] https://crrev.com/555009cefe4c8706b0f6305bd320b4254b40e4ee/src/tests/gl_tests/UniformBufferTest.cpp
,
Nov 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf4d8f4e8ca46c12e420cc57ed39bfa349ec47a2 commit bf4d8f4e8ca46c12e420cc57ed39bfa349ec47a2 Author: jmadill <jmadill@chromium.org> Date: Thu Nov 17 03:57:51 2016 Roll ANGLE 9863a3e..555009c https://chromium.googlesource.com/angle/angle.git/+log/9863a3e..555009c BUG= chromium:593024 , 661413 , 602737 TBR=zmo@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2506143003 Cr-Commit-Position: refs/heads/master@{#432733} [modify] https://crrev.com/bf4d8f4e8ca46c12e420cc57ed39bfa349ec47a2/DEPS
,
Nov 17 2016
,
Nov 17 2016
Great job, Jamie!
,
Nov 17 2016
Thanks Jamie for following up on this! It'll surely improve the portability of WebGL 2.0 content.
,
Nov 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a3d5bb723798e2f672fea9ccf8c57275296a177 commit 8a3d5bb723798e2f672fea9ccf8c57275296a177 Author: jmadill <jmadill@chromium.org> Date: Thu Nov 17 21:39:21 2016 WebGL: Update Windows Intel expectations. The texture shadow 2D array tests are flakily crashing. Also remove the Win7 UBO failure expectations. BUG= 593024 , 666392 TBR=zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2511193002 Cr-Commit-Position: refs/heads/master@{#432968} [modify] https://crrev.com/8a3d5bb723798e2f672fea9ccf8c57275296a177/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by shreks...@gmail.com
, Mar 8 2016