New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 593018 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

PLT.PT.NavigationStartToFirstLayout is not logged for every page load

Project Member Reported by bmcquade@chromium.org, Mar 8 2016

Issue description

PLT.PT.NavigationStartToFirstLayout is logged once per RenderViewObserver, rather than once per page load. We should remove it and migrate users to PageLoad.Timing2.NavigationToFirstLayout which is logged correctly.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/267cd99070e74fc51e38d278f5a557275064c21d

commit 267cd99070e74fc51e38d278f5a557275064c21d
Author: bmcquade <bmcquade@chromium.org>
Date: Thu Mar 10 16:33:16 2016

Remove incorrect PLT.PT.NavigationStartToFirstLayout histogram

This is a revert of https://codereview.chromium.org/1230513002

The logic for this histogram incorrectly assumes that a RenderViewObserver's
lifetime is tied to a single page load. This is incorrect: a RVO is tied to the
lifetime of a RenderView, which can live for many page loads. Thus, the logic to
compute and emit this histogram is incorrect. We've since added new page load
histograms under PageLoad.*, and there is a
PageLoad.Timing2.NavigationToFirstLayout which is correctly emitted once per
page load. Thus, we are deprecating PLT.PT.NavigationStartToFirstLayout in favor
of PageLoad.Timing2.NavigationToFirstLayout.

BUG= 593018 

Review URL: https://codereview.chromium.org/1774873002

Cr-Commit-Position: refs/heads/master@{#380418}

[modify] https://crrev.com/267cd99070e74fc51e38d278f5a557275064c21d/chrome/renderer/page_load_histograms.cc
[modify] https://crrev.com/267cd99070e74fc51e38d278f5a557275064c21d/chrome/renderer/page_load_histograms.h
[modify] https://crrev.com/267cd99070e74fc51e38d278f5a557275064c21d/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Untriaged)

Sign in to add a comment