New issue
Advanced search Search tips

Issue 593017 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Rename GESTURE to TOUCHSCREEN in cc::InputHandler::ScrollInputType

Project Member Reported by dtapu...@chromium.org, Mar 8 2016

Issue description

With the addition of wheel based gesture scrolling; the definition of GESTURE in cc::InputHandler::ScrollInputType is confusing.
 
Owner: dtapu...@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40e8aff900f1c7be05b3e6d68aae1504e116a8d8

commit 40e8aff900f1c7be05b3e6d68aae1504e116a8d8
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Mar 11 21:45:03 2016

Rename InputHandler::GESTURE to InputHandler::TOUCHSCREEN

Since mouse wheel events will use gestures. Make it clear that this
scroll input type was really referring to touchscreen.

Rename executed via:
sed -i 's/InputHandler::GESTURE/InputHandler::TOUCHSCREEN/g'
git cl format

BUG= 593017 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1775013004

Cr-Commit-Position: refs/heads/master@{#380742}

[modify] https://crrev.com/40e8aff900f1c7be05b3e6d68aae1504e116a8d8/cc/input/input_handler.h
[modify] https://crrev.com/40e8aff900f1c7be05b3e6d68aae1504e116a8d8/cc/layers/scrollbar_layer_unittest.cc
[modify] https://crrev.com/40e8aff900f1c7be05b3e6d68aae1504e116a8d8/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/40e8aff900f1c7be05b3e6d68aae1504e116a8d8/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/40e8aff900f1c7be05b3e6d68aae1504e116a8d8/cc/trees/layer_tree_host_unittest_scroll.cc

Status: Fx (was: Started)
Status: Fixed (was: Fx)

Sign in to add a comment