New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 593002 link

Starred by 1 user
Status: Fixed
Owner:
eugene...@chromium.org
Closed: Mar 2016
Cc:
marq@chromium.org
█ shrey...@chromium.org
ios-bugs@chromium.org
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

plugin_placeholder.js - inconsistent return type

Project Member Reported by justincohen@chromium.org, Mar 8 2016 
[3090/7310] RULE Running closure compiler on plugin_placeholder.js
web_state/js/resources/plugin_placeholder.js:53: WARNING - inconsistent return type
found   : Node
required: (HTMLElement|null)
          return node.childNodes[i];
                 ^

0 error(s), 1 warning(s), 88.8% typed

Comment 1 by eugene...@chromium.org, Mar 8 2016

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c25fd6e76ccbbcf0f58ff5a45700d2af319569a

commit 1c25fd6e76ccbbcf0f58ff5a45700d2af319569a
Author: eugenebut <eugenebut@chromium.org>
Date: Tue Mar 08 17:54:36 2016

[ios] Corrected Closure annotation for getEmbedChild_ function.

Old annotation was HTMLElement, new one is Node.

BUG= 593002 

Review URL: https://codereview.chromium.org/1779453002

Cr-Commit-Position: refs/heads/master@{#379854}

[modify] https://crrev.com/1c25fd6e76ccbbcf0f58ff5a45700d2af319569a/ios/web/web_state/js/resources/plugin_placeholder.js

Comment 3 by eugene...@chromium.org, Mar 8 2016

Status: Fixed (was: Started)
►

Sign in to add a comment