New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 592998 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

overlord: web UI enhancement

Project Member Reported by wnhuang@chromium.org, Mar 8 2016

Issue description

This is a bug used for tracking various of overlord UI enhancement changes.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/8a0133a99b8563f44d056f283efe3d5ec7ee47ad

commit 8a0133a99b8563f44d056f283efe3d5ec7ee47ad
Author: Wei-Ning Huang <wnhuang@google.com>
Date: Tue Mar 08 13:04:03 2016

overlord: always display disconnection overlay

Previously we only want to display disconnection overlay when websocket
connection is not closed by the user. Since it's hard to actually track
of the disconnetion is triggered by user, we remove this behavior and
always show the disconnetion overlay instead.

BUG= chromium:592998 
TEST=manually

Change-Id: Ie21720ca1545e62c85ca862dd4ae8035a55b1cef
Reviewed-on: https://chromium-review.googlesource.com/331511
Commit-Ready: Wei-Ning Huang <wnhuang@chromium.org>
Tested-by: Wei-Ning Huang <wnhuang@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/8a0133a99b8563f44d056f283efe3d5ec7ee47ad/go/src/overlord/app/common/js/TerminalWindow.jsx

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/d2af3b4a427749f650b815618f78b5772c090efa

commit d2af3b4a427749f650b815618f78b5772c090efa
Author: Wei-Ning Huang <wnhuang@google.com>
Date: Tue Mar 08 12:57:03 2016

overlord: allow opening multiple terminal window for a target

Allow multiple terminal window to be opened for a single target. We
previously don't allow it because file download relies on browser ID.
After we introduce the concept of a terminal session ID this is no
longer a restriction.

BUG= chromium:592998 
TEST=open multiple terminal window in dashboard app

Change-Id: Ib448bdb280d96d209f17e78b60d108fd626bef9a
Reviewed-on: https://chromium-review.googlesource.com/331510
Commit-Ready: Wei-Ning Huang <wnhuang@chromium.org>
Tested-by: Wei-Ning Huang <wnhuang@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/d2af3b4a427749f650b815618f78b5772c090efa/go/src/overlord/app/common/js/utils.js
[modify] https://crrev.com/d2af3b4a427749f650b815618f78b5772c090efa/go/src/overlord/app/common/js/TerminalWindow.jsx
[modify] https://crrev.com/d2af3b4a427749f650b815618f78b5772c090efa/go/src/overlord/app/dashboard/js/view.jsx

Status: Fixed (was: Assigned)

Sign in to add a comment