Some services expect that logged-in users also have an initialized profile |
||||
Issue descriptionExtensionGarbageCollector and ProfileHelper assume that any logged in users will also have an initialized profile. This is not the case, because the profile initialization process can take arbitrarily long (for example, if there is a network connectivity issue while trying to load policy). We should update this code to check for an initialized profile explicitly rather than rely on the user's logged-in state as a proxy.
,
Mar 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f17bcd66f045d27078a29fc0ace0fa993cec3274 commit f17bcd66f045d27078a29fc0ace0fa993cec3274 Author: atwilson <atwilson@chromium.org> Date: Wed Mar 30 13:08:11 2016 Fixed a few places that incorrectly assumed that profile was initialized While testing a fix for crbug.com/532317, I found a few places in the code that assumed that logged-in users would always have an associated profile. However, it can take arbitrarily long from the time that a user logs in until their profile finishes initialization, so code should not make this assumption. This CL fixes the extension garbage collector and ProfileHelper to properly handle uninitialized profiles. BUG= 592993 Review URL: https://codereview.chromium.org/1773113002 Cr-Commit-Position: refs/heads/master@{#383960} [modify] https://crrev.com/f17bcd66f045d27078a29fc0ace0fa993cec3274/chrome/browser/extensions/extension_garbage_collector_chromeos.cc [modify] https://crrev.com/f17bcd66f045d27078a29fc0ace0fa993cec3274/chrome/browser/profiles/profile_manager.cc
,
Mar 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f17bcd66f045d27078a29fc0ace0fa993cec3274 commit f17bcd66f045d27078a29fc0ace0fa993cec3274 Author: atwilson <atwilson@chromium.org> Date: Wed Mar 30 13:08:11 2016 Fixed a few places that incorrectly assumed that profile was initialized While testing a fix for crbug.com/532317, I found a few places in the code that assumed that logged-in users would always have an associated profile. However, it can take arbitrarily long from the time that a user logs in until their profile finishes initialization, so code should not make this assumption. This CL fixes the extension garbage collector and ProfileHelper to properly handle uninitialized profiles. BUG= 592993 Review URL: https://codereview.chromium.org/1773113002 Cr-Commit-Position: refs/heads/master@{#383960} [modify] https://crrev.com/f17bcd66f045d27078a29fc0ace0fa993cec3274/chrome/browser/extensions/extension_garbage_collector_chromeos.cc [modify] https://crrev.com/f17bcd66f045d27078a29fc0ace0fa993cec3274/chrome/browser/profiles/profile_manager.cc
,
Apr 5 2016
,
Apr 5 2016
Fix is in 51.0.2695.1 (CrOS 8136.0.0). Will verify in M51-Dev 8136.0.0 or later. Is there a need to merge this to M50?
,
Apr 6 2016
How can we test this?Could you share some steps that could help in testing initializedprofile.
,
Apr 6 2016
In my case, I actually modified the code to force a network timeout when trying to access DMServer. If you want to test this, you could set your router to blackhole m.google.com (so it doesn't respond with any packets at all) and try to add a managed user.
,
Apr 13 2016
Regression looks ok on Peppy M ChromeOS Chrome Type Channel 51 8176.0.0 51.0.2701.0 release dev
,
May 2 2016
All programs supposed |
||||
►
Sign in to add a comment |
||||
Comment 1 by scunning...@chromium.org
, Mar 8 2016