New issue
Advanced search Search tips

Issue 592976 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

Clicking ImeWindow should not set input context.

Project Member Reported by azurewei@chromium.org, Mar 8 2016

Issue description

OS: <Linux, Windows>

When clicking an ImeWidow, the InputMethodBase::SetFocusedTextInputClient() is triggered to set the current input context handler while the window is not really focused. Thus, calling other APIs (such as input.ime.commitText/setComposition) could not run well with the wrong 'foucsed' input context handler.

What steps will reproduce the problem?
(1) Call input.ime.createWindow to create an ui::ImeWindow.
(2) Click the window with mouse.
(3) InputMethodBase::SetFocusedTextInputClient() is called to set the input context handler on ui::ImeBridge.

 
Components: UI>Input>Text>IME
Labels: M-51
Labels: -Pri-2 Pri-1
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/772101175f0445dd93990a5f3c169ec62def9710

commit 772101175f0445dd93990a5f3c169ec62def9710
Author: shuchen <shuchen@chromium.org>
Date: Wed Mar 09 05:56:44 2016

Set the current input context handler when the toplevel window is activated instead of when the input field is focused.

When the input field is focused, the top level window may not be active.
For example, the IME window inactivatable, however, the embedded web
contents has its own window and tries to set the focused text input
client when it recieves the mouse down events.

BUG=517773, 592976 

Review URL: https://codereview.chromium.org/1778693004

Cr-Commit-Position: refs/heads/master@{#380081}

[modify] https://crrev.com/772101175f0445dd93990a5f3c169ec62def9710/ui/base/ime/input_method_base.cc

Status: Fixed (was: Assigned)

Sign in to add a comment