New issue
Advanced search Search tips

Issue 592947 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 27
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 582792



Sign in to add a comment

PlatforMouseEvent.m_region should move to HitTestResults or some other part of MouseEventWithTestResults.

Project Member Reported by jinho.b...@samsung.com, Mar 8 2016

Issue description

Current implementation of canvas hit region saves the id of hit region to PlatformMouseEvent in case of MouseEvent. This isn't right way.
We should move the region id to HitTestResults or some other parts.
 
Blocking: 582792
Components: Blink>Canvas
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3192926ec460259b66e2d6a6bc07e05049105eed

commit 3192926ec460259b66e2d6a6bc07e05049105eed
Author: hs1217.lee <hs1217.lee@samsung.com>
Date: Sat Aug 20 09:57:06 2016

add HitTestCanvasResult Class instend of std::pair<Element*, String>

HitRegion is need to many information to expand(ie. cursor, parent_id, label, etc) in canvas2d.
"std::pair<element*, string>" can't have a lot of information.
so HitTestCanvasResult was added to expend.

BUG= 592947 

Review-Url: https://codereview.chromium.org/2229743003
Cr-Commit-Position: refs/heads/master@{#413330}

[modify] https://crrev.com/3192926ec460259b66e2d6a6bc07e05049105eed/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/3192926ec460259b66e2d6a6bc07e05049105eed/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/3192926ec460259b66e2d6a6bc07e05049105eed/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/3192926ec460259b66e2d6a6bc07e05049105eed/third_party/WebKit/Source/core/html/HTMLCanvasElement.h
[modify] https://crrev.com/3192926ec460259b66e2d6a6bc07e05049105eed/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
[modify] https://crrev.com/3192926ec460259b66e2d6a6bc07e05049105eed/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/3192926ec460259b66e2d6a6bc07e05049105eed/third_party/WebKit/Source/core/input/TouchEventManager.cpp
[add] https://crrev.com/3192926ec460259b66e2d6a6bc07e05049105eed/third_party/WebKit/Source/core/layout/HitTestCanvasResult.cpp
[add] https://crrev.com/3192926ec460259b66e2d6a6bc07e05049105eed/third_party/WebKit/Source/core/layout/HitTestCanvasResult.h
[modify] https://crrev.com/3192926ec460259b66e2d6a6bc07e05049105eed/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/3192926ec460259b66e2d6a6bc07e05049105eed/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h

Owner: ----
Status: WontFix (was: Assigned)
The HitRegion feature was abandoned.

Sign in to add a comment