New issue
Advanced search Search tips

Issue 592938 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

hterm/nassh should have option to support font ligatures

Project Member Reported by mtp@google.com, Mar 8 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.116 Safari/537.36

Steps to reproduce the problem:
A variety of modern monospace fonts support ligatures for common sequences: Monoid (http://larsenwork.com/monoid/) or Pragmata Pro (http://www.fsd.it/shop/fonts/pragmatapro/) as common examples.

A variety of terminal emulaters across platforms support replacing common sequences with ligatures: Konsole (Linux and BSD); Terminal (base Mac OS X).

Apparently even Atom supports ligature as well: http://blog.atom.io/2015/10/29/atom-1-1-is-out.html.

What is the expected behavior?
HTerm/nassh offers option for ligature.

What went wrong?
No support.

WebStore page: https://chrome.google.com/webstore/detail/secure-shell/pnhechapfaindjhompbnflcldabbghjo

Did this work before? N/A 

Chrome version: 48.0.2564.116  Channel: stable
OS Version: OS X 10.11.3
Flash Version: Shockwave Flash 20.0 r0
 

Comment 1 Deleted

Comment 2 Deleted

Comment 3 by vapier@chromium.org, Jan 31 2017

Labels: -Type-Bug -Pri-2 -OS-Mac OS-All Pri-3 Type-Feature
Status: Available (was: Unconfirmed)
we turned off style ligatures on purpose via  issue 621519  because some fonts do stupid ones like ff or ae.  if you want to turn them on explicitly, you can do so via the already existing user-css option.  this has been covered here:
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/chromium-hterm/DOkAKJhgnyI/p5VqT_-bAAAJ

we can see about adding an option though.

Comment 4 by vapier@chromium.org, May 19 2017

Owner: vapier@chromium.org
Status: Fixed (was: Available)
we have a user-css-text field now.  you can put this in there to enable ligatures:

x-row {
  text-rendering: optimizeLegibility;
  font-variant-ligatures: normal;
}

i tried with Monoid and it seems to work.  

i'll add a FAQ to cover this.  i don't think it's worth adding an option now that we have inline user-css-text options.
Project Member

Comment 5 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/4d3883247237a9df78c1897481b97831ed7c3619

commit 4d3883247237a9df78c1897481b97831ed7c3619
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon May 22 21:08:39 2017

nassh: FAQ: add a section on font ligatures

BUG= chromium:592938 

Change-Id: I21e256f577300d901cd35d37e6ab7bda87c36cc0
Reviewed-on: https://chromium-review.googlesource.com/509388
Reviewed-by: Brandon Gilmore <varz@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/4d3883247237a9df78c1897481b97831ed7c3619/nassh/doc/FAQ.md

Project Member

Comment 6 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/4d3883247237a9df78c1897481b97831ed7c3619

commit 4d3883247237a9df78c1897481b97831ed7c3619
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon May 22 21:08:39 2017

nassh: FAQ: add a section on font ligatures

BUG= chromium:592938 

Change-Id: I21e256f577300d901cd35d37e6ab7bda87c36cc0
Reviewed-on: https://chromium-review.googlesource.com/509388
Reviewed-by: Brandon Gilmore <varz@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/4d3883247237a9df78c1897481b97831ed7c3619/nassh/doc/FAQ.md

Sign in to add a comment