New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 592931 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Calculation of height:auto without containing box explicit height is changed since M50

Reported by christop...@gmail.com, Mar 8 2016

Issue description

Chrome Version       : 50.0.2661.11 dev (64-bit)
URLs (if applicable) : Atlassian Confluence (tested on v5.5.7, v5.9.1 and 6.0.0-OD-2016.10.0-1054
Other browsers tested:
     Safari: OK
    Firefox: OK
         IE: not-tested

What steps will reproduce the problem?
(1) Go on any Confluence site and hit edit button.
(2) Edit view will be displayed but with a very small edit area (see screeni)

I can't provide a test page but you can create your own trail account on https://www.atlassian.com/software/confluence/try . But as Confluence is not so rare used in software development i guess you may have already somewhere an account.


What is the expected result?
Full browser area is used for edit page.

What happens instead?
Only a small edit area is displayed but anyway the normal view mode is displaying it on full browser area. In the stable version 49 it still works like a charm so i guess this is browser bug but not sure if there is an JS issue maybe.


 
edit_mode_bug.png
95.9 KB View Download
Cc: junov@chromium.org rnimmagadda@chromium.org
Components: Blink>Editing
Labels: M-50 OS-Linux OS-Mac OS-Windows
Owner: dfalcant...@chromium.org
Status: Assigned (was: Unconfirmed)
====================================

Good Build:

50.0.2628.0    Base Position: 370939


Bad Build:

50.0.2629.0    Base Position: 371142

=====================================

Able to repro this issue on Windows 7, MAC (10.11.3) & Ubuntu Trusty (14.04) for the Google Chrome Canary Version - 51.0.2672.0

This is a regression issue broken in M50, below mentioned is the bisect info:

CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/e0b6a82cadecbda7e005921c2416fc7afb3542aa..1fee3b4957164505e70df4152fa31a2807fefa74

Suspecting the below:

=============================================================

526a7f4c610f0f4a0859c199e8cd4fcedcb8234d 

Review URL: https://codereview.chromium.org/1618283006

======================= OR ==================================

e0906ef875c59ab9355e44e506b1e08f223844f2

Review URL: https://codereview.chromium.org/1613513004

=============================================================

@junov/dfalcantara: Could you please look into the issue, and if it has nothing to do with your changes and if possible please do assign it to the concerned owner.

Thank you.
Cc: -junov@chromium.org
Owner: junov@chromium.org
Don't know who a concerned owner would be; mine is an Android-only change.  No possible way it could have affected blink, of all things.  Punting to junov.

Comment 3 by yosin@chromium.org, Mar 10 2016

Cc: -rnimmagadda@chromium.org junov@chromium.org
Owner: rnimmagadda@chromium.org
Summary: NEEDS_FEEDBACK: Chrome breaks Confluence Edit Mode (was: Chrome breaks Confluence Edit Mode)
rnimmagadda@, could you provide test page? 
It seems lots of steps need to get trial site.
Hi together,

i just checked the changelog. And just saw the change "Treat percent-height div inside auto-height cells as auto" (https://chromium.googlesource.com/chromium/src/+/8876584335b48c99cf8df552ef4d8efebb131041). As i have played around a bit with the CSS. The HTML Structure of that edit part is as following:
<div id="wysiwyg" style="width: 100%; height: 100%;">
   <div id="rte" class="cell editor-fullheight">
       <textarea id="wysiwygTextarea" name="wysiwygContent" class="hidden tinymce-editor" aria-hidden="true" style="display: none;"></textarea>
       <iframe id="wysiwygTextarea_ifr" src='javascript:""' frameborder="0" allowtransparency="true" title="{#aria.rich_text_area}" style="width: 100%; height: 100%; display: block;" tabindex="100"></iframe>
   </div>
</div>

The editor-fullheight class def looks like that:

.editor-fullheight {
    height: 100%;
}

So it is a 100% div in a 100% div. If i change the editor-fullheight height attribute to a pixel value (e.g. 500px) it grows to that value. So from my stumage feeling i would say this change interfers with old behavior.
I wasn't able to isolate it to that with an test page, that does only have that HTML snipped in it as the 49er Chrome version makes that editor div also that small like the 50 version. So there is maybe something that i am missing here around that block (but i can't provide full page source due to legal issues :( ).

But maybe this statement helps to find the root cause :)

As far as i can see this issue here is the same as mentioned in this comment: https://bugs.chromium.org/p/chromium/issues/detail?id=346275#c37

You may want to align with developers there especially about the guess with auto-height fix. :)
Cc: yosin@chromium.org rnimmagadda@chromium.org
Labels: -Type-Bug Needs-Feedback Type-Bug-Regression
Owner: ----
Status: Unconfirmed (was: Assigned)
@yosin: Ran the bisect again and got the same result as mentioned in the comment #1

Test Page:

https://chrometesting69.atlassian.net/wiki/pages/editpage.action?pageId=1179655 [Please sign-up and create your login]

Please email me your email ID [separately], so that I can share the credentials.

Screen-recording is attached.

Thank you.
592931.mov
3.9 MB Download

Comment 7 by yosin@chromium.org, Mar 16 2016

Components: -Blink>Editing Blink>Layout
Labels: -Needs-Feedback
Owner: e...@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Calculation of height:auto without containing box explicit height is changed since M50 (was: NEEDS_FEEDBACK: Chrome breaks Confluence Edit Mode)
Changes to Blink>Layout, this is caused by changes of height:auto calculation between M49 and M51.

>#6,  rnimmagadda@, how do I sign up? I could not find "Sign Up" link in the URI specified in #6.

In below HTML, I saw "End of div" and "End of body" at bottom page and they are overlapped.

Per CSS spec, percentage "height" property is treated as "auto" if there is no containing box having explicit "height".

<style>
.editor-fullheight {
    height: 100%;
}
</style>
<div id="wysiwyg" style="width: 100%; height: 100%;">
   <div id="rte" class="cell editor-fullheight">
       <textarea id="wysiwygTextarea" name="wysiwygContent" class="hidden tinymce-editor" aria-hidden="true" style="display: none;"></textarea>
       <iframe id="wysiwygTextarea_ifr" src='javascript:""' frameborder="0" allowtransparency="true" title="{#aria.rich_text_area}" style="width: 100%; height: 100%; display: block;" tabindex="100"></iframe>End of div
   </div>
</div>
End of body


@yosin: Here is the link to Login - https://chrometesting69.atlassian.net/login?
 Issue 594987  has been merged into this issue.

Comment 10 by e...@chromium.org, Apr 1 2016

Labels: Needs-Evangelism
Status: WontFix (was: Assigned)
This was an intentional change to match the spec and other browsers. Comment 7 above details the steps required to fix this issue.

Sign in to add a comment