New issue
Advanced search Search tips

Issue 592907 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression

Blocking:
issue webrtc:5607



Sign in to add a comment

2.8%-36.6% regression in webrtc_perf_tests at 11874:11874

Project Member Reported by hlundin@chromium.org, Mar 8 2016

Issue description

This is due to https://codereview.webrtc.org/1750353002 and must be fixed.

 
Labels: -M-48 -Pri-2 M-51 OS-All Pri-1
Cc: peah@chromium.org
Blocking: webrtc:5607
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/d72595eeea4812f33bc7e23ec4c2bfcc99adac2f

commit d72595eeea4812f33bc7e23ec4c2bfcc99adac2f
Author: henrik.lundin <henrik.lundin@webrtc.org>
Date: Thu Mar 10 10:26:29 2016

Fix NetEq performance test regression

The test code created an AudioBuffer object inside the work loop. This
turned out to be expensive, since the AudioBuffer ctor implicitly
called memset on all of the audio data array. The obvious remedy is to
create the buffer outside of the loop. This does not have any impact
apart from the performance boost, since the output data from NetEq is
not even considered in the test.

BUG= chromium:592907 , webrtc:5647 
TBR=ivoc@webrtc.org
NOTRY=true

Review URL: https://codereview.webrtc.org/1782803002

Cr-Commit-Position: refs/heads/master@{#11940}

[modify] https://crrev.com/d72595eeea4812f33bc7e23ec4c2bfcc99adac2f/webrtc/modules/audio_coding/neteq/tools/neteq_performance_test.cc
[modify] https://crrev.com/d72595eeea4812f33bc7e23ec4c2bfcc99adac2f/webrtc/modules/include/module_common_types.h

Status: Fixed (was: Assigned)
All graphs have recovered with the fix in #5.

Sign in to add a comment