New issue
Advanced search Search tips

Issue 592906 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

content_unittests failing on GinJavaBridgeValueConverterTest.TypedArrays on several android testers

Project Member Reported by nyquist@chromium.org, Mar 8 2016

Issue description

Failing suite: content_unittests
Failing test: GinJavaBridgeValueConverterTest.TypedArrays

First failures:
Marshmallow Tablet Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/3117
Marshmallow 64 bit Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/1010
Lollipop Tablet Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/2108
Lollipop Phone Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/3403
Lollipop Low-end Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Low-end%20Tester/builds/2681

Looking at the start and end of ranges from those bots, the smallest range is:
https://chromium.googlesource.com/chromium/src/+log/99df23ce1484300e3eba3656d7c1151fc69d01b7~..3e2a6e297b8d59e106c31ae3ddcd8ee53316acbd

I was using a recently flashed Nexus 5 with a LMY48T userdebug build.

I edited build/android/pylib/local/device/local_device_gtest_run.py by removing content_unittests from _SUITE_REQUIRES_TEST_SERVER_SPAWNER since I did not need to use the remote forwarder setup for this test. I then ran a git bisect:

$ git bisect start
$ git checkout 3e2a6e297b8d59e106c31ae3ddcd8ee53316acbd
$ git bisect bad
$ git checkout 99df23ce1484300e3eba3656d7c1151fc69d01b7
$ git bisect good
$ git bisect run bash -c 'git checkout build/android/pylib/local/device/local_device_gtest_run.py && GYP_CHROMIUM_NO_ACTION=1 gclient sync -r src@HEAD && cp ~/Desktop/local_device_gtest_run.py build/android/pylib/local/device/local_device_gtest_run.py && time CHROMIUM_OUT_DIR="out-android" ninja -j10000 -l30 -C out-android/Debug content_unittests_apk_run && ./out-android/Debug/bin/run_content_unittests -v --gtest_filter="GinJavaBridgeValueConverterTest.TypedArrays"'

This clearly identified the culprit:
<snip>
3013584d091473d3a5fee6a823bc63b223a472c is the first bad commit
commit 83013584d091473d3a5fee6a823bc63b223a472c
Author: dgozman <dgozman@chromium.org>
Date:   Mon Mar 7 09:28:32 2016 -0800

    Use v8::MicrotasksScope internally in V8RecursionScope.

    If this sticks we can just remove V8RecursionScope and WebScopedMicrotaskSuppression,
    along with other cleanups.

    BUG= 585949 

    Review URL: https://codereview.chromium.org/1743763004

    Cr-Commit-Position: refs/heads/master@{#379574}

:040000 040000 8530b052649aa1baaa96f89aff8d396f8b03b98d d30333a11aa1ec6ee65eb50137c58d163f9f14ab M      chrome
:040000 040000 9ea17bd3900f3c1b1d2b6f0c8b65b478b4471227 73b1397414533d6e1f78a366260ee7372c3a0ed2 M      content
:040000 040000 b4ddaf8e3db8143073ff77f3c5c77b2d1b3969ad 69d65ec584436630b6bdf7bca6da02e351420212 M      extensions
:040000 040000 9d853021e0e94ec97a58697f63c1183bd4a6c0e5 d4abf392a9143a264b6014f10299ec1f65556420 M      gin
:040000 040000 fa54625c3317340dddc607b48db83af8d90edf4f 93243d90d80d1edd49f39cba39550d18e0e5db5d M      third_party
bisect run success
<snip>
 
Status: Assigned (was: Untriaged)
Reverted offending CL in https://codereview.chromium.org/1765423004/
Status: Fixed (was: Assigned)

Sign in to add a comment