New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 592876 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Sep 2016
Cc:
dpranke@chromium.org
ojan@chromium.org
alancutter@chromium.org
█ wkorman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Outdated rebaseline generated for mac retina

Project Member Reported by cavalcantii@chromium.org, Mar 8 2016 
On issue https://codereview.chromium.org/1770713002/ I asked for new rebaselines to be generated.

It seems that it didn't update the text expectations for retina platform, as mentioned on:
https://codereview.chromium.org/1770713002/#msg14

Weird part is that last change on the failing expectations have the hash 7fdb98cd72204a342026a7213cbaa19bf87ab88b and commit log:

Date:   Mon Mar 7 13:27:15 2016 -0800

    Auto-rebaseline for r379608
    
    https://chromium.googlesource.com/chromium/src/+/125a2daee
    
    BUG= 559258 , 581870 
    TBR=cavalcantii@chromium.org
    
    Review URL: https://codereview.chromium.org/1773853002 .
    
    Cr-Commit-Position: refs/heads/master@{#379646}


Maybe the bot skipped some step for mac retina?

Comment 1 by wkorman@chromium.org, Mar 8 2016

Components: Blink>Tools>Test
The baselines are supposed to fall back as retina -> mac-retina -> mac per:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mac.py&q=mac.py&sq=package:chromium&type=cs&l=46

It sounds like retina implementation is sort of a hack, it would not surprise me if there is a bug around how we handle baseline optimization. Will investigate when I get a chance, thanks for filing.

Comment 2 by sshru...@google.com, Mar 18 2016

Components: -Blink>Tools>Test Blink>ToolsTest
Fixing component name after Monorail migration

Comment 3 by tansell@chromium.org, Mar 30 2016

Status: Started (was: Untriaged)

Comment 4 by wkorman@chromium.org, Mar 30 2016

Cc: wkorman@chromium.org
Owner: tansell@chromium.org
tansell@ are you looking at this? Passing to you presumptively, thanks.

Comment 5 by sshru...@google.com, Apr 18 2016

Components: -Blink>ToolsTest Blink>Infra
Blink>ToolsTest renamed to Blink>Infra

Comment 6 by tansell@chromium.org, Jun 7 2016

Cc: dpranke@chromium.org ojan@chromium.org
Owner: ----
Status: Available (was: Started)
Nope. I'm not looking at this. 

I believe someone was working on this though. ojan@ / dpranke@ do you know who that was?

Comment 7 by dpranke@chromium.org, Jun 7 2016 

Nope.

Comment 8 by qyears...@chromium.org, Sep 9 2016

Status: Archived (was: Available)
►

Sign in to add a comment