New issue
Advanced search Search tips

Issue 592856 link

Starred by 1 user
Status: Fixed
Owner:
karandeepb@chromium.org
Closed: Mar 2016
Cc:
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 579380



Sign in to add a comment

MacViews: Failing bubble views_unittests after r375729

Project Member Reported by tapted@chromium.org, Mar 8 2016 
Chrome Version       : 50.0.2652.0
OS Version: OS X 10.11.3

5 views_unittests regressed with r375729 "MacViews: Add native drop shadow to dialogs on OSX 10.9.":

BubbleBorderTest.GetBoundsOriginTest (../../ui/views/bubble/bubble_border_unittest.cc:321)
BubbleBorderTest.GetSizeForContentsSizeTest (../../ui/views/bubble/bubble_border_unittest.cc:212)
BubbleFrameViewTest.GetMaximumSize (../../ui/views/bubble/bubble_frame_view_unittest.cc:438)
BubbleFrameViewTest.GetMinimumSize (../../ui/views/bubble/bubble_frame_view_unittest.cc:429)
BubbleFrameViewTest.GetPreferredSize (../../ui/views/bubble/bubble_frame_view_unittest.cc:419)

It's probably to do with forcing the shadow type to NO_ASSETS when the tests expect something else.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e2dad5dbc48da995987c7c4e27d419a9879fd83

commit 6e2dad5dbc48da995987c7c4e27d419a9879fd83
Author: karandeepb <karandeepb@chromium.org>
Date: Tue Mar 08 23:56:10 2016

MacViews: Fix failing bubble border tests after r375729.

r375729 changed all the bubble borders on MacViews to use
BubbleBorder::NO_ASSETS. This caused the following tests to regress-
    BubbleBorderTest.GetBoundsOriginTest
    BubbleBorderTest.GetSizeForContentsSizeTest

These tests regressed since they use kImages->top_arrow which is not set for
BubbleBorder::NO_ASSETS. This CL fixes these tests by using kImages->arrow_width
instead.

BUG= 592856 

Review URL: https://codereview.chromium.org/1778473002

Cr-Commit-Position: refs/heads/master@{#379981}

[modify] https://crrev.com/6e2dad5dbc48da995987c7c4e27d419a9879fd83/ui/views/bubble/bubble_border_unittest.cc

Comment 2 by karandeepb@chromium.org, Mar 9 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59a5f4fd9d5b761d459878a1616a4c76bce36183

commit 59a5f4fd9d5b761d459878a1616a4c76bce36183
Author: karandeepb <karandeepb@chromium.org>
Date: Tue Mar 15 01:43:35 2016

MacViews: Fix failing bubble frame view tests after r375729.

r375729 changed all the bubble borders on MacViews to use
BubbleBorder::NO_ASSETS. This caused the following tests to regress-
    BubbleFrameViewTest.GetMaximumSize
    BubbleFrameViewTest.GetMinimumSize
    BubbleFrameViewTest.GetPreferredSize

These tests regressed since the constants kExpectedBorderHeight and
kExpectedBorderWidth are set as per BubbleBorder::NO_SHADOWS. This CL fixes
these tests by getting the border insets programmatically, rather than depending
on fixed constants.

BUG= 592856 

Review URL: https://codereview.chromium.org/1774923002

Cr-Commit-Position: refs/heads/master@{#381148}

[modify] https://crrev.com/59a5f4fd9d5b761d459878a1616a4c76bce36183/ui/views/bubble/bubble_frame_view_unittest.cc

Comment 4 by karandeepb@chromium.org, Mar 15 2016

Status: Fixed (was: Started)

Comment 5 by lafo...@chromium.org, Apr 20 2016

Labels: -Hotlist-MacViews Proj-MacViews
►

Sign in to add a comment