New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 592847 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression



Sign in to add a comment

"Show page size on resize" option in render settings not persistent.

Reported by valentin...@gmail.com, Mar 8 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.11 Safari/537.36

Steps to reproduce the problem:
1. Enable "Show page size on resize".
2. Close chrome.
3. Open chrome, "Show page size on resize" option is un-checked.

What is the expected behavior?
The selected option to persist between chrome sessions.

What went wrong?
The page size fixed in https://bugs.chromium.org/p/chromium/issues/detail?id=582421 is not persistent.

Did this work before? Yes Chrome 48 (non dev)

Chrome version: 50.0.2661.11  Channel: dev
OS Version: 10.0
Flash Version: Shockwave Flash 21.0 r0
 

Comment 1 by alph@chromium.org, Mar 8 2016

Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)
Labels: -OS-Windows -Type-Bug M-50 OS-All Type-Bug-Regression
Status: Started (was: Assigned)
Labels: Merge-Request-50
Verified on mac canary 51.0.2673.0.

Comment 5 by tin...@google.com, Mar 11 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)

Comment 6 by gov...@chromium.org, Mar 11 2016

Please try to merge your change to M50 branch 2661 ASAP if you think it is a safe merge as we're close to M50 Beta candidate cut for next week. Thank you.

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 15 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81c1f124a8a6258f075b51b474abaf3bd9ce4d09

commit 81c1f124a8a6258f075b51b474abaf3bd9ce4d09
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Mar 15 18:22:01 2016

Merge to 2661 "[DevTools] Show viewport size on resize by default, disable in device mode."
> [DevTools] Show viewport size on resize by default, disable in device mode.
>
> BUG= 592847 
>
> Review URL: https://codereview.chromium.org/1771853004
>
> Cr-Commit-Position: refs/heads/master@{#380212}

(cherry picked from commit 5e9b5ed287ad4e8a91e7e99e6b426a2ae9897f5a)
TBR=pfeldman

Review URL: https://codereview.chromium.org/1807573002 .

Cr-Commit-Position: refs/branch-heads/2661@{#241}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/81c1f124a8a6258f075b51b474abaf3bd9ce4d09/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js
[modify] https://crrev.com/81c1f124a8a6258f075b51b474abaf3bd9ce4d09/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/81c1f124a8a6258f075b51b474abaf3bd9ce4d09/third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js

Status: Fixed (was: Started)
Cc: rnimmagadda@chromium.org
Labels: Needs-Feedback
@valentino.belardi: Could you please let us know where exactly we can see the option "Show page size on resize" in the Rendering Settings in DevTools. Could you please provide us the screen-recording for better understanding.

Please find the attached screen-recording.

Moreover, the UI is now appearing as reported in the issue beneath.

https://bugs.chromium.org/p/chromium/issues/detail?id=582421

Thank you.
592847.mp4
3.2 MB Download
Sure, this option is available in version 50.0.2661.18 under Render Settings.

When I submitted this case, it was listed under 50.0.2661.11, which still had this option available.


chrome-devtools-render-setting-options.png
201 KB View Download
@valentino.belardi: Do we need to enable any flag to see this option?

Since I was not able to see it in Chrome Beta Version - 50.0.2661.37
Screen Shot 2016-03-16 at 2.55.26 PM.png
80.4 KB View Download
I am sure the option has been removed in the newer builds as it has been enabled by default when not in device mode, as mentioned in the above fix.
Labels: -Needs-Feedback TE-Verified-M50 TE-Verified-50.0.2661.37
Verified the fix on Windows 7, MAC (10.11.3) & Ubuntu Trusty (14.04) for Google Chrome Beta Version - 50.0.2661.37 

Screen-recording & Screen-shot are attached.

TE-Verified labels are added.
Thanks for the confirmation, I have upgraded the dev version to 51.0.2679.0 and all is working as expected.
 Issue 596004  has been merged into this issue.

Sign in to add a comment