Make SoftwareImageDecodeController::DecodedImage not be ref counted. |
|||
Issue descriptionRight now it's ref counted because the mru cache we store it in doesn't support move only types. After move only support lands, change it to be a scoped ptr.
,
Mar 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61c1b9da83fd9783d23421735c6a777899c6b127 commit 61c1b9da83fd9783d23421735c6a777899c6b127 Author: vmpstr <vmpstr@chromium.org> Date: Fri Mar 11 23:55:38 2016 cc: ImageDecodes: Remove ref counting from SIDC::DecodedImage. This patch removes ref counting from DecodedImage class in SoftwareImageDecodeController. BUG= 592823 R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1778673005 Cr-Commit-Position: refs/heads/master@{#380789} [modify] https://crrev.com/61c1b9da83fd9783d23421735c6a777899c6b127/cc/tiles/software_image_decode_controller.cc [modify] https://crrev.com/61c1b9da83fd9783d23421735c6a777899c6b127/cc/tiles/software_image_decode_controller.h
,
Mar 14 2016
Stack trace: ============= go/crash/92a69bb400000000 Thread 4 CRASHED [EXCEPTION_BREAKPOINT @ 0x00007ffa4085b1dd ] MAGIC SIGNATURE THREAD 0x00007ffa4085b1dd (chrome_child.dll -logging.cc:737 ) logging::LogMessage::~LogMessage() 0x00007ffa4133db4d (chrome_child.dll -memory.cc:19 ) base::`anonymous namespace'::OnNoMemory 0x00007ffa4238b1ad (chrome_child.dll -child_discardable_shared_memory_manager.cc:311 ) content::ChildDiscardableSharedMemoryManager::AllocateLockedDiscardableSharedMemory(unsigned __int64,int) 0x00007ffa4238adca (chrome_child.dll -child_discardable_shared_memory_manager.cc:186 ) content::ChildDiscardableSharedMemoryManager::AllocateLockedDiscardableMemory(unsigned __int64) 0x00007ffa413ec761 (chrome_child.dll -software_image_decode_controller.cc:344 ) cc::SoftwareImageDecodeController::DecodeImageInternal(cc::ImageDecodeControllerKey const &,cc::DrawImage const &) 0x00007ffa413ed4d2 (chrome_child.dll -software_image_decode_controller.cc:509 ) cc::SoftwareImageDecodeController::GetDecodedImageForDrawInternal(cc::ImageDecodeControllerKey const &,cc::DrawImage const &) 0x00007ffa413eca5d (chrome_child.dll -software_image_decode_controller.cc:387 ) cc::SoftwareImageDecodeController::DecodeImageInternal(cc::ImageDecodeControllerKey const &,cc::DrawImage const &) 0x00007ffa413ec372 (chrome_child.dll -software_image_decode_controller.cc:286 ) cc::SoftwareImageDecodeController::DecodeImage(cc::ImageDecodeControllerKey const &,cc::DrawImage const &) 0x00007ffa413eb339 (chrome_child.dll -software_image_decode_controller.cc:54 ) cc::`anonymous namespace'::ImageDecodeTaskImpl::RunOnWorkerThread 0x00007ffa424a11c7 (chrome_child.dll -raster_worker_pool.cc:364 ) content::RasterWorkerPool::RunTaskInCategoryWithLockAcquired(cc::TaskCategory) 0x00007ffa424a12b3 (chrome_child.dll -raster_worker_pool.cc:339 ) content::RasterWorkerPool::RunTaskWithLockAcquired(std::vector<cc::TaskCategory,std::allocator<cc::TaskCategory> > const &) 0x00007ffa424a1098 (chrome_child.dll -raster_worker_pool.cc:233 ) content::RasterWorkerPool::Run(std::vector<cc::TaskCategory,std::allocator<cc::TaskCategory> > const &,base::ConditionVariable *) 0x00007ffa4088385f (chrome_child.dll -simple_thread.cc:66 ) base::SimpleThread::ThreadMain() 0x00007ffa4087572f (chrome_child.dll -platform_thread_win.cc:84 ) base::`anonymous namespace'::ThreadFunc 0x00007ffa893dc901 (KERNEL32.DLL + 0x0000c901 ) BaseThreadInitThunk 0x00007ffa8b97bf93 (ntdll.dll + 0x0004bf93 ) RtlUserThreadStart vmpstr@: Could you please confirm if this issue is working towards fixing the [Out of Memory] cc::SoftwareImageDecodeController::DecodeImageInternal. Seeing three digit crash instances of this crash on all the M-51 channel builds since chrome version: 51.0.2666.0. Link to the list of the builds with this crash can be seen here: ================================================================= https://crash.corp.google.com/browse?q=custom_data.ChromeCrashProto.ptype%3D%27renderer%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BOut%20of%20Memory%5D%20cc%3A%3ASoftwareImageDecodeController%3A%3ADecodeImageInternal%27%20AND%20product.name%3D%27Chrome%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D#-samplereports:5,productversion:30 Note: Not marking this Blocker as of now, due to [Out of memory] in the magic signature.
,
Mar 16 2016
vmpstr@: Can we get an update if this OOM can be ignored. Crash with magic signature: [Out of Memory] cc::SoftwareImageDecodeController::DecodeImageInternal is the 5th top crasher on the latest dev(51.0.2679.0) now.
,
Mar 16 2016
Hi, this bug is about tracking removing ref counting from SoftwareImageDecodeController. I don't think the patches here are affecting the crash rate in any way. There is a bug here https://bugs.chromium.org/p/chromium/issues/detail?id=577786 that is/was tracking the out of memory issues.
,
Mar 16 2016
,
Mar 15 2018
How to fix this crash, You can find in attachmenet
,
Mar 15 2018
From the log it seems like your system is running out of memory,increase the system memory/ exit from the programs which you are not using. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Mar 9 2016