New issue
Advanced search Search tips

Issue 592820 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: [regression] do not go back and forth via utf8 in the debugger/runtime agents

Project Member Reported by pfeldman@chromium.org, Mar 8 2016

Issue description

We should new NewFromOne/TwoByte instead.
 
Summary: DevTools: [regression] do not go back and forth via utf8 in the debugger/runtime agents (was: DevTools: [regression] do not go back and forth via urf8 in the debugger/runtime agents)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0599b75469cb6edec440ec4c6ec1f3bc29b383f6

commit 0599b75469cb6edec440ec4c6ec1f3bc29b383f6
Author: pfeldman <pfeldman@chromium.org>
Date: Tue Mar 08 03:34:01 2016

DevTools: [regression] do not go back and forth via utf8 in the debugger/runtime agents.

BUG= 592820 
NOTRY=true

Review URL: https://codereview.chromium.org/1767343002

Cr-Commit-Position: refs/heads/master@{#379716}

[modify] https://crrev.com/0599b75469cb6edec440ec4c6ec1f3bc29b383f6/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp

Labels: Merge-Request-50 M-50
Status: Started (was: Assigned)

Comment 5 by tin...@google.com, Mar 9 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Please try to merge your change to M50 branch 2661 ASAP if you think it is a safe merge as we're very close to M50 Beta candidate cut. Thank you.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 9 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e3512146551aabb7aa8e6428ebac0bbb1af7d40

commit 4e3512146551aabb7aa8e6428ebac0bbb1af7d40
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Wed Mar 09 18:31:50 2016

DevTools: [regression] do not go back and forth via utf8 in the debugger/runtime agents.

BUG= 592820 
NOTRY=true

Review URL: https://codereview.chromium.org/1767343002

Cr-Commit-Position: refs/heads/master@{#379716}
(cherry picked from commit 0599b75469cb6edec440ec4c6ec1f3bc29b383f6)

Review URL: https://codereview.chromium.org/1784463002 .

Cr-Commit-Position: refs/branch-heads/2661@{#144}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/4e3512146551aabb7aa8e6428ebac0bbb1af7d40/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp

Status: Fixed (was: Started)

Sign in to add a comment