New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 592817 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

tbody.deleteRow(-1) should remove the last row

Project Member Reported by tkent@chromium.org, Mar 8 2016

Issue description

Version: 51 canary
OS: All

What steps will reproduce the problem?
(1) Open http://w3c-test.org/html/semantics/tabular-data/the-tbody-element/deleteRow.html

What is the expected output? What do you see instead?
Expected: No FAIL test
Actual: The last one fails.


Please use labels and text to provide additional information.

https://html.spec.whatwg.org/multipage/tables.html#dom-tbody-deleterow
> If index is −1, remove the last element in the rows collection from its parent.

We throws an exception now.


 
Owner: ramy...@samsung.com
Status: Assigned (was: Available)
Would like to work on this bug.
Added a patch at https://codereview.chromium.org/1771043004/
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c4a630b476aa829cacd0b8fb7d716d5d993692e

commit 0c4a630b476aa829cacd0b8fb7d716d5d993692e
Author: ramya.v <ramya.v@samsung.com>
Date: Tue Mar 08 07:11:31 2016

tbody.deleteRow(-1) should never throw an exception

As per spec
https://html.spec.whatwg.org/multipage/tables.html#dom-tbody-deleterow
If index is -1, remove the last element in the rows collection from its
parent. Should not throw exception in this case if row is empty.

BUG= 592817 

Review URL: https://codereview.chromium.org/1771043004

Cr-Commit-Position: refs/heads/master@{#379771}

[delete] https://crrev.com/f844066a491c02fba7e0fa27faeb0d639d37c5b1/third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow-expected.txt
[modify] https://crrev.com/0c4a630b476aa829cacd0b8fb7d716d5d993692e/third_party/WebKit/Source/core/html/HTMLTableSectionElement.cpp

Status: Fixed (was: Assigned)

Comment 4 by tkent@chromium.org, Mar 8 2016

Labels: M-51

Sign in to add a comment