Collect failed compile "target" from ninja on Waterfall. |
||||
Issue description(A "target" here is a node in ninja's build graph.) After next ninja release (version 1.7), ninja will print the output nodes of the failed edges. An edge is an execution task in ninja. We wanted to collect such info to: 1. Speed up culprit-finding by minimizing the number of tasks to be executed by ninja during rerun of compile. 2. Confirm whether a re-run of compile fails for the same reason as those on the Waterfall. 3. De-duplicate same compile failures across different build configurations on the Waterfall. (This could reduce the number of culprit-finding try-jobs for the same compile failures on different bots.)
,
Mar 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/8f5d6b5fbb6086297bb8bbb26b6f7392766ba53b commit 8f5d6b5fbb6086297bb8bbb26b6f7392766ba53b Author: stgao <stgao@chromium.org> Date: Tue Mar 15 20:23:27 2016 [Findit] Collect failed output nodes of compile and link failures by strict regex This is a temporary solution before the ninja 1.7 is released and used by all bots. This worth a try as it speeds up the culprit-finding try-jobs so much. BUG= 592808 Review URL: https://codereview.chromium.org/1799313002 [modify] https://crrev.com/8f5d6b5fbb6086297bb8bbb26b6f7392766ba53b/appengine/findit/handlers/config.py [modify] https://crrev.com/8f5d6b5fbb6086297bb8bbb26b6f7392766ba53b/appengine/findit/handlers/test/config_test.py [modify] https://crrev.com/8f5d6b5fbb6086297bb8bbb26b6f7392766ba53b/appengine/findit/waterfall/extractors.py [modify] https://crrev.com/8f5d6b5fbb6086297bb8bbb26b6f7392766ba53b/appengine/findit/waterfall/test/extractors_test.py [modify] https://crrev.com/8f5d6b5fbb6086297bb8bbb26b6f7392766ba53b/appengine/findit/waterfall/test/try_job_util_test.py [modify] https://crrev.com/8f5d6b5fbb6086297bb8bbb26b6f7392766ba53b/appengine/findit/waterfall/test/waterfall_config_test.py [modify] https://crrev.com/8f5d6b5fbb6086297bb8bbb26b6f7392766ba53b/appengine/findit/waterfall/try_job_util.py [modify] https://crrev.com/8f5d6b5fbb6086297bb8bbb26b6f7392766ba53b/appengine/findit/waterfall/waterfall_config.py
,
Mar 15 2016
,
Mar 22 2016
The CL to collect failed "target"s directly from ninja is https://codereview.chromium.org/1766873002/, but might need some tweaking after release of ninja 1.7
,
Apr 22 2016
,
Apr 25 2017
Mark as fixed because the recipe change to collect failed targets on the recipe side seems not preferred by nico. |
||||
►
Sign in to add a comment |
||||
Comment 1 by st...@chromium.org
, Mar 8 2016