New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 592806 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Increase delay between reboot and device list

Project Member Reported by krisr@chromium.org, Mar 8 2016

Issue description

See job: http://cautotest/afe/#tab_id=view_job&object_id=56051940

From the logs:
03/07 14:33:15.283 DEBUG|          adb_host:0333| Command: adb -s 00bef4a8897b34ea root
03/07 14:33:15.283 DEBUG|          ssh_host:0153| Running (ssh) 'adb -s 00bef4a8897b34ea root'
03/07 14:33:15.700 DEBUG|        base_utils:0268| [stdout] adbd is already running as root
03/07 14:33:16.707 DEBUG|          adb_host:0333| Command: adb -s 00bef4a8897b34ea wait-for-device
03/07 14:33:16.708 DEBUG|          ssh_host:0153| Running (ssh) 'adb -s 00bef4a8897b34ea wait-for-device'
03/07 14:33:16.866 DEBUG|          adb_host:0333| Command: adb -s 00ce42aa89f32aeb reboot
03/07 14:33:16.867 DEBUG|          ssh_host:0153| Running (ssh) 'adb -s 00ce42aa89f32aeb reboot'
03/07 14:33:17.173 DEBUG|          adb_host:0333| Command: adb -s 00ce42aa89f32aeb devices
03/07 14:33:17.174 DEBUG|          ssh_host:0153| Running (ssh) 'adb -s 00ce42aa89f32aeb devices'
03/07 14:33:17.327 DEBUG|        base_utils:0268| [stdout] List of devices attached
03/07 14:33:17.328 DEBUG|        base_utils:0268| [stdout] 8c01dc6f	device
03/07 14:33:17.328 DEBUG|        base_utils:0268| [stdout] 00bef4a8897b34ea	device
03/07 14:33:17.329 DEBUG|        base_utils:0268| [stdout] 8bfcdc63	device
03/07 14:33:17.329 DEBUG|        base_utils:0268| [stdout] 8bfcdc82	device
03/07 14:33:17.329 DEBUG|        base_utils:0268| [stdout] 8bfcdcf5	device
03/07 14:33:17.329 DEBUG|        base_utils:0268| [stdout] HT4BTWV00397	device
03/07 14:33:17.329 DEBUG|        base_utils:0268| [stdout] HT4BTWV00492	device
03/07 14:33:17.330 DEBUG|        base_utils:0268| [stdout] 00e16ac389583cb8	device
03/07 14:33:17.330 DEBUG|        base_utils:0268| [stdout] 00d3f80489db16f8	device
03/07 14:33:17.330 DEBUG|        base_utils:0268| [stdout] 84B7N15A10013423	device
03/07 14:33:17.330 DEBUG|        base_utils:0268| [stdout] 84B7N15A28011432	device
03/07 14:33:17.330 DEBUG|        base_utils:0268| [stdout] ZX1G22L2QQ	device
03/07 14:33:17.331 DEBUG|        base_utils:0268| [stdout] ZX1G22JRHC	device
03/07 14:33:17.331 DEBUG|        base_utils:0268| [stdout] 84B7N15A28012456	device
03/07 14:33:17.331 DEBUG|        base_utils:0268| [stdout] ZX1G22KMZ6	device
03/07 14:33:17.331 DEBUG|        base_utils:0268| [stdout] ZX1G22KTSC	device
03/07 14:33:17.332 DEBUG|        base_utils:0268| [stdout] 84B7N15A28016105	device
03/07 14:33:17.332 DEBUG|        base_utils:0268| [stdout] HT4BTWV00463	device
03/07 14:33:17.332 DEBUG|        base_utils:0268| [stdout] HT4BTWV00097	device
03/07 14:33:17.332 DEBUG|        base_utils:0268| [stdout] 
03/07 14:33:17.336 DEBUG|          adb_host:0532| Found Device: 8c01dc6f
03/07 14:33:17.336 DEBUG|          adb_host:0532| Found Device: 00bef4a8897b34ea
03/07 14:33:17.337 DEBUG|          adb_host:0532| Found Device: 8bfcdc63
03/07 14:33:17.337 DEBUG|          adb_host:0532| Found Device: 8bfcdc82
03/07 14:33:17.337 DEBUG|          adb_host:0532| Found Device: 8bfcdcf5
03/07 14:33:17.337 DEBUG|          adb_host:0532| Found Device: HT4BTWV00397
03/07 14:33:17.338 DEBUG|          adb_host:0532| Found Device: HT4BTWV00492
03/07 14:33:17.338 DEBUG|          adb_host:0532| Found Device: 00e16ac389583cb8
03/07 14:33:17.338 DEBUG|          adb_host:0532| Found Device: 00d3f80489db16f8
03/07 14:33:17.338 DEBUG|          adb_host:0532| Found Device: 84B7N15A10013423
03/07 14:33:17.338 DEBUG|          adb_host:0532| Found Device: 84B7N15A28011432
03/07 14:33:17.339 DEBUG|          adb_host:0532| Found Device: ZX1G22L2QQ
03/07 14:33:17.339 DEBUG|          adb_host:0532| Found Device: ZX1G22JRHC
03/07 14:33:17.339 DEBUG|          adb_host:0532| Found Device: 84B7N15A28012456
03/07 14:33:17.339 DEBUG|          adb_host:0532| Found Device: ZX1G22KMZ6
03/07 14:33:17.340 DEBUG|          adb_host:0532| Found Device: ZX1G22KTSC
03/07 14:33:17.340 DEBUG|          adb_host:0532| Found Device: 84B7N15A28016105
03/07 14:33:17.340 DEBUG|          adb_host:0532| Found Device: HT4BTWV00463
03/07 14:33:17.341 DEBUG|          adb_host:0532| Found Device: HT4BTWV00097
03/07 14:33:17.341 DEBUG|          adb_host:0333| Command: adb -s 00ce42aa89f32aeb get-state
03/07 14:33:17.341 DEBUG|          ssh_host:0153| Running (ssh) 'adb -s 00ce42aa89f32aeb get-state'
03/07 14:33:17.499 ERROR|        base_utils:0268| [stderr] error: device '00ce42aa89f32aeb' not found
03/07 14:33:17.501 ERROR|             reset:0031| command execution error
* Command: 
    /usr/bin/ssh -a -x  -o ControlPath=/tmp/_autotmp_FNqIGqssh-master/socket
    -o StrictHostKeyChecking=no -o UserKnownHostsFile=/tmp/tmpED5ez8 -o
    BatchMode=yes -o ConnectTimeout=30 -o ServerAliveInterval=300 -l root -p
    22 android1758-row1-rack5-test-station-2 " adb -s 00ce42aa89f32aeb get-
    state"
Exit status: 1
Duration: 0.117218017578

stderr:
error: device '00ce42aa89f32aeb' not found

Here are the two times:
03/07 14:33:16.867 DEBUG|ssh_host:0153| Running (ssh) 'adb -s 00ce42aa89f32aeb reboot'
03/07 14:33:17.174 DEBUG|ssh_host:0153| Running (ssh) 'adb -s 00ce42aa89f32aeb devices'

Since all of the phones are OEM unlocked there is a "dev mode" screen that displays for a few seconds, so the code will need to wait for that.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/18848d47e1c8e7331f7a76e1361c4f587d69585a

commit 18848d47e1c8e7331f7a76e1361c4f587d69585a
Author: Dan Shi <dshi@google.com>
Date: Wed Mar 09 21:25:28 2016

[autotest] Bug fix in waiting for ADBHost.is_up

When multiple devices are connected to a test bed, we should only run
is_device_ready when `adb devices` command lists the serial of the
device. Otherwise, is_device_ready call will fail with an error.

BUG= chromium:592806 
TEST=local run test.

Change-Id: I15f9004be68cc29535d82236e2f53e4da34dd45b
Reviewed-on: https://chromium-review.googlesource.com/331785
Commit-Ready: Dan Shi <dshi@google.com>
Tested-by: Dan Shi <dshi@google.com>
Reviewed-by: Kevin Cheng <kevcheng@chromium.org>

[modify] https://crrev.com/18848d47e1c8e7331f7a76e1361c4f587d69585a/server/hosts/adb_host.py

Comment 3 by dshi@chromium.org, Apr 17 2016

Status: Fixed (was: Assigned)

Sign in to add a comment