New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 592790 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 591620



Sign in to add a comment

Measure PFQ success rate

Project Member Reported by steve...@chromium.org, Mar 7 2016

Issue description

In order to define a PFQ CodeYellow SLO based on PFQ success rate, we need to measure the success rate.

I would like to measure the success rate of each individual builder, and of the PFQ master.

I think that the SLO should include an average value for the individual builders, and one for the master, e.g. individual builders have a 99% success rate and the master has a 90% success rate.


 
Owner: akes...@chromium.org
akeshet@ - do you have any suggestions for the best mechanism for querying and displaying these values? Do we have any existing precedent for other builders?

Assigning this to you for now to investigate and/or reassign; feel free to assign back if you don't have cycles.

Summary: Measure PFQ success rate (was: Measure PFQ failure rate)
Cc: -steve...@chromium.org dgarr...@chromium.org steve...@chromium.orgm
Owner: steve...@chromium.org
In chromite:

bin/summarize_build_stats - Looks at the recent performance of different master build types, and summarizes. (also, looks at annotations)

bin/build_time_stats - Can be configured to look at various configs, examine their timings or pass/fail rate. A lot of changes lately, this tool is evolving.


Both of these are backed by the same mysql database -- cidb. In principle you could build any service you like that queries it. Or, you could extend these scripts.
Status: Started (was: Available)
Labels: -gardener Hotlist-CrOSGardener
Labels: Hotlist-CrOS-Gardener
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/bf26542044d0cebf40bd74de663692df9ad5ca91

commit bf26542044d0cebf40bd74de663692df9ad5ca91
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Sat Mar 12 01:27:44 2016

Add '--report success' to build_time_stats to generate success rate stats.

BUG= chromium:592790 
TEST=TBD

Change-Id: I734809ed93e4a6f0cc0e2dff0452fcc9808b733a
Reviewed-on: https://chromium-review.googlesource.com/332621
Commit-Ready: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/bf26542044d0cebf40bd74de663692df9ad5ca91/lib/build_time_stats.py
[modify] https://crrev.com/bf26542044d0cebf40bd74de663692df9ad5ca91/scripts/build_time_stats.py

Status: Fixed (was: Started)
Example build_time_stats command:

~/chromeos/chromite $ ./bin/build_time_stats --cred-dir ~/Work/prod_cidb_readonly --build-type chrome-pfq --report success --log-level warning --start-date 2016-04-25 --end-date 2016-05-01 --csv > apr_25.csv

Stats are being tracked here:

https://docs.google.com/spreadsheets/d/1JnEQNEFhnBhncv_COqLC5hQC9Ge9oMjww5Xv-7mzIks/edit#gid=0

Status: Verified (was: Fixed)
Bulk verified

Sign in to add a comment