We have - core/dom/CharacterData.h, and - platform/fonts/CharacterData.h. Both have |#define CharacterData_h|. We should rename the latter because the former is defined by the DOM standard.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e373cd743be884678f12e136800802d12603d953 commit e373cd743be884678f12e136800802d12603d953 Author: kojii <kojii@chromium.org> Date: Thu Mar 10 06:33:40 2016 Rename platform/fonts/CharacterData.h to avoid conflict with core/dom BUG= 592780 Review URL: https://codereview.chromium.org/1780523003 Cr-Commit-Position: refs/heads/master@{#380362} [modify] https://crrev.com/e373cd743be884678f12e136800802d12603d953/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/e373cd743be884678f12e136800802d12603d953/third_party/WebKit/Source/platform/blink_platform.gyp [modify] https://crrev.com/e373cd743be884678f12e136800802d12603d953/third_party/WebKit/Source/platform/fonts/Character.cpp [rename] https://crrev.com/e373cd743be884678f12e136800802d12603d953/third_party/WebKit/Source/platform/fonts/CharacterPropertyData.cpp [rename] https://crrev.com/e373cd743be884678f12e136800802d12603d953/third_party/WebKit/Source/platform/fonts/CharacterPropertyDataGenerator.cpp [rename] https://crrev.com/e373cd743be884678f12e136800802d12603d953/third_party/WebKit/Source/platform/fonts/CharacterPropertyDataGenerator.h [modify] https://crrev.com/e373cd743be884678f12e136800802d12603d953/third_party/WebKit/Source/platform/platform_generated.gyp
Thanks for taking care of this, Koji!
Comment 1 by drott@chromium.org
, Mar 8 2016