New issue
Advanced search Search tips

Issue 592758 link

Starred by 3 users
Status: Fixed
Owner:
rharrison@chromium.org
Closed: Jan 2018
Cc:
thestig@chromium.org
tsepez@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocked on:
issue 656648
Blocking:
issue 62400



Sign in to add a comment

Pdf XFA: Crash when opening drop-down

Project Member Reported by aval...@chromium.org, Mar 7 2016 
Version: 7c1c27414ff9e29a88fec8f717b4c157363bfae6

Logging stack trace here but could not reproduce.

#0 0x7f5c9c614f9b base::debug::(anonymous namespace)::StackDumpSignalHandler()
#1 0x7f5c945d3340 <unknown>
#2 0x7f5c9cf0e2bf CFX_GEFont::GetCharWidth()
#3 0x7f5c9cf16255 CFX_TxtBreak::AppendChar_Others()
#4 0x7f5c9cf16472 CFX_TxtBreak::AppendChar()
#5 0x7f5c9cf031f0 CFDE_TextOut::CalcTextSize()
#6 0x7f5c9cea3d2e CXFA_FWLTheme::CalcTextRect()
#7 0x7f5c9cf2d71f CFWL_WidgetImp::CalcTextSize()
#8 0x7f5c9cf8be33 CFWL_ListBoxImp::GetMaxTextWidth()
#9 0x7f5c9cf89ebf CFWL_ListBoxImp::CalcSize()
#10 0x7f5c9cf8a605 CFWL_ListBoxImp::Update()
#11 0x7f5c9cf8819e CFWL_ComboBoxImp::DisForm_ShowDropList()
#12 0x7f5c9cf88985 CFWL_ComboBoxImpDelegate::DisForm_OnProcessMessage()
#13 0x7f5c9cf2b7c5 CFWL_NoteDriver::DispatchMessage()
#14 0x7f5c9cf2b54f CFWL_NoteDriver::ProcessMessage()
#15 0x7f5c9cf2f917 CFWL_WidgetMgrDelegate::OnProcessMessageToForm()
#16 0x7f5c9cf3e711 CXFA_FFField::OnLButtonDown()
#17 0x7f5c9cea0492 CXFA_FFWidgetHandler::OnLButtonDown()
#18 0x7f5c9cd15793 CPDFSDK_PageView::OnLButtonDown()
#19 0x7f5c9cd00daf FORM_OnLButtonDown
#20 0x7f5c9c5f6550 chrome_pdf::PDFiumEngine::OnMouseDown()
#21 0x7f5c9c5f5f7b chrome_pdf::PDFiumEngine::HandleEvent()
#22 0x7f5c9c607ae9 chrome_pdf::OutOfProcessInstance::HandleInputEvent()
#23 0x7f5c9c502313 pp::InputEvent_HandleEvent()
#24 0x7f5c9b7d9c52 ppapi::proxy::PPP_InputEvent_Proxy::OnMsgHandleFilteredInputEvent()
#25 0x7f5c9b7d9b9d _ZN3IPC8MessageTI52PpapiMsg_PPPInputEvent_HandleFilteredInputEvent_MetaSt5tupleIJiN5ppapi14InputEventDataEEES2_IJ7PP_BoolEEE8DispatchINS3_5proxy20PPP_InputEvent_ProxyESB_vMSB_FviRKS4_PS6_EEEbPKNS_7MessageEPT_PT0_PT1_T2_
#26 0x7f5c9b7d9aa0 ppapi::proxy::PPP_InputEvent_Proxy::OnMessageReceived()
#27 0x7f5c9b7ae3ad ppapi::proxy::Dispatcher::OnMessageReceived()
#28 0x7f5c9b7c2f96 ppapi::proxy::PluginDispatcher::OnMessageReceived()
#29 0x7f5c998f527d IPC::ChannelProxy::Context::OnDispatchMessage()
#30 0x7f5c9c61608c base::debug::TaskAnnotator::RunTask()
#31 0x7f5c9c62c5ab base::MessageLoop::RunTask()
#32 0x7f5c9c62c898 base::MessageLoop::DeferOrRunPendingTask()
#33 0x7f5c9c62ca4b base::MessageLoop::DoWork()
#34 0x7f5c9c62de3a base::MessagePumpDefault::Run()
#35 0x7f5c9c6449e0 base::RunLoop::Run()
#36 0x7f5c9c62befa base::MessageLoop::Run()
#37 0x7f5c9c3430bd content::PpapiPluginMain()
#38 0x7f5c9c5ef02a content::RunZygote()
#39 0x7f5c9c5efe92 content::ContentMainRunnerImpl::Run()
#40 0x7f5c9c5eec10 content::ContentMain()
#41 0x7f5c988076ca ChromeMain
#42 0x7f5c916deec5 __libc_start_main
#43 0x7f5c988075a1 <unknown>
  r8: 0000000000000000  r9: 0000000000000000 r10: 0000000000000009 r11: 0000000000000010
 r12: 000024e227bd4260 r13: 0000000000000060 r14: 0000000000000041 r15: 0000000000000000
  di: 000024e2275883f0  si: 000024e2281d2630  bp: 000024e2281d2630  bx: 00007ffc08a3c40c
  dx: 0000000000000041  ax: 0000000000000001  cx: 00007ffc08a3c40c  sp: 00007ffc08a3c3c0
  ip: 00007f5c9cf0e2bf efl: 0000000000010206 cgf: 0000000000000033 erf: 0000000000000004
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000011

Comment 1 by aval...@chromium.org, Mar 7 2016 

Forgot to attach the crashing pdf.
IMM5257E.pdf
424 KB Download

Comment 2 by dsinclair@chromium.org, Oct 17 2016

Blocking: 62400

Comment 3 by dsinclair@chromium.org, Oct 19 2016

Blockedon: 656648

Comment 4 by dsinclair@chromium.org, Dec 15 2016

Owner: dsinclair@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by dsinclair@chromium.org, Sep 19 2017

Owner: rharrison@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 12 2018 

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/9baf31f8c38e1c5266609e184cc07e369b744760

commit 9baf31f8c38e1c5266609e184cc07e369b744760
Author: Ryan Harrison <rharrison@chromium.org>
Date: Fri Jan 12 18:36:30 2018

Use enum for tracking form field types

Within PDFium use enum class for better type safety when working with
form field types. These values will still be converted to ints as part
of the public API, since that is the existing API.

This work is preperation for extending the number of form field types
to have more specific entries for XFA.

BUG=pdfium:952, chromium:763129 , chromium:592758 

Change-Id: Ie6c29f02ae22be782ff36eb87d27f1a4bf2c099e
Reviewed-on: https://pdfium-review.googlesource.com/22742
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>

[modify] https://crrev.com/9baf31f8c38e1c5266609e184cc07e369b744760/fpdfsdk/cpdfsdk_widget.cpp
[modify] https://crrev.com/9baf31f8c38e1c5266609e184cc07e369b744760/fpdfsdk/cpdfsdk_interform.cpp
[modify] https://crrev.com/9baf31f8c38e1c5266609e184cc07e369b744760/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp
[modify] https://crrev.com/9baf31f8c38e1c5266609e184cc07e369b744760/core/fpdfdoc/cpdf_formfield.cpp
[modify] https://crrev.com/9baf31f8c38e1c5266609e184cc07e369b744760/fpdfsdk/formfiller/cffl_formfiller.cpp
[modify] https://crrev.com/9baf31f8c38e1c5266609e184cc07e369b744760/fpdfsdk/fpdfformfill.cpp
[modify] https://crrev.com/9baf31f8c38e1c5266609e184cc07e369b744760/public/fpdf_formfill.h
[modify] https://crrev.com/9baf31f8c38e1c5266609e184cc07e369b744760/core/fpdfdoc/cpdf_formfield.h
[modify] https://crrev.com/9baf31f8c38e1c5266609e184cc07e369b744760/fpdfsdk/cpdfsdk_interform.h
[modify] https://crrev.com/9baf31f8c38e1c5266609e184cc07e369b744760/fpdfsdk/cpdfsdk_widgethandler.cpp
[modify] https://crrev.com/9baf31f8c38e1c5266609e184cc07e369b744760/fpdfsdk/cpdfsdk_formfillenvironment.cpp
[modify] https://crrev.com/9baf31f8c38e1c5266609e184cc07e369b744760/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp
[modify] https://crrev.com/9baf31f8c38e1c5266609e184cc07e369b744760/fpdfsdk/cpdfsdk_widget.h
[modify] https://crrev.com/9baf31f8c38e1c5266609e184cc07e369b744760/samples/pdfium_test.cc
[modify] https://crrev.com/9baf31f8c38e1c5266609e184cc07e369b744760/core/fpdfdoc/cpdf_interform.cpp
[modify] https://crrev.com/9baf31f8c38e1c5266609e184cc07e369b744760/testing/embedder_test.cpp
[modify] https://crrev.com/9baf31f8c38e1c5266609e184cc07e369b744760/fxjs/cjs_field.cpp
[modify] https://crrev.com/9baf31f8c38e1c5266609e184cc07e369b744760/fxjs/cjs_publicmethods.cpp

Comment 7 by rharrison@chromium.org, Jan 12 2018

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76473d4ff59feae08fe50d714f30564357bafeea

commit 76473d4ff59feae08fe50d714f30564357bafeea
Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org>
Date: Fri Jan 12 21:39:34 2018

Roll src/third_party/pdfium/ 72d34be06..9baf31f8c (1 commit)

https://pdfium.googlesource.com/pdfium.git/+log/72d34be06324..9baf31f8c38e

$ git log 72d34be06..9baf31f8c --date=short --no-merges --format='%ad %ae %s'
2018-01-12 rharrison Use enum for tracking form field types

Created with:
  roll-dep src/third_party/pdfium
BUG= 763129 , 592758 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I33672afa8d0c4fb4a27c02487afb1849d921569d
Reviewed-on: https://chromium-review.googlesource.com/864634
Commit-Queue: <pdfium-deps-roller@chromium.org>
Reviewed-by: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529070}
[modify] https://crrev.com/76473d4ff59feae08fe50d714f30564357bafeea/DEPS
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 16 2018 

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/2056fac754e679baea695390854fe7b0ce7acb28

commit 2056fac754e679baea695390854fe7b0ce7acb28
Author: Ryan Harrison <rharrison@chromium.org>
Date: Tue Jan 16 16:06:45 2018

Add support for XFA specific FormField types

This adds to form field types specific types for XFA form fields to be
used instead of the generic XFA value when possible.

BUG=pdfium:952, chromium:763129 , chromium:592758 

Change-Id: I8d1cff6a280d71db348b7c31a251cbe2e398ec79
Reviewed-on: https://pdfium-review.googlesource.com/22677
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>

[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/xfa/fxfa/cxfa_fflistbox.cpp
[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/fpdfsdk/cpdfsdk_interform.cpp
[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/xfa/fxfa/cxfa_ffcombobox.h
[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/fpdfsdk/fpdfformfill.cpp
[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/xfa/fxfa/cxfa_fftextedit.h
[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/xfa/fxfa/cxfa_ffcheckbutton.cpp
[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/xfa/fxfa/cxfa_ffwidget.cpp
[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/xfa/fxfa/cxfa_ffpushbutton.h
[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/core/fpdfdoc/cpdf_formfield.h
[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/xfa/fxfa/cxfa_ffsignature.cpp
[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/public/fpdf_formfill.h
[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/xfa/fxfa/cxfa_ffcheckbutton.h
[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/xfa/fxfa/cxfa_fflistbox.h
[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/xfa/fxfa/cxfa_fftextedit.cpp
[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/xfa/fxfa/cxfa_ffcombobox.cpp
[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/xfa/fxfa/cxfa_ffpushbutton.cpp
[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/xfa/fxfa/cxfa_ffwidget.h
[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/xfa/fxfa/cxfa_ffsignature.h
[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/xfa/fxfa/cxfa_ffimageedit.h
[modify] https://crrev.com/2056fac754e679baea695390854fe7b0ce7acb28/xfa/fxfa/cxfa_ffimageedit.cpp
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9078c967aba033d5338a2606b01b616b3f7521c5

commit 9078c967aba033d5338a2606b01b616b3f7521c5
Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org>
Date: Tue Jan 16 18:45:05 2018

Roll src/third_party/pdfium/ d3ae179da..2615590b0 (6 commits)

https://pdfium.googlesource.com/pdfium.git/+log/d3ae179dab3f..2615590b040a

$ git log d3ae179da..2615590b0 --date=short --no-merges --format='%ad %ae %s'
2018-01-16 hnakashima Add FPDF_GetPageBoundingBox API.
2018-01-16 rharrison Add support for XFA specific FormField types
2018-01-16 wangqing-hf Add support for pdfium use partitionalloc on loongson platform.
2018-01-16 dsinclair Rename CXFA_Value methods for clarity
2018-01-16 dsinclair Rename CXFA_Validate methods for clarity
2018-01-16 dsinclair Rename CXFA_Line methods to make clearer

Created with:
  roll-dep src/third_party/pdfium
BUG= 763129 , 592758 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I5203d9580e4183b2ecded38f85e9964ab4a1802a
Reviewed-on: https://chromium-review.googlesource.com/868032
Commit-Queue: <pdfium-deps-roller@chromium.org>
Reviewed-by: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529472}
[modify] https://crrev.com/9078c967aba033d5338a2606b01b616b3f7521c5/DEPS

Comment 11 by rharrison@chromium.org, Jan 17 2018

Status: Fixed (was: Started)
Fixed by https://chromium-review.googlesource.com/c/chromium/src/+/860876
►

Sign in to add a comment