New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 592757 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----

Blocked on:
issue 601155
issue 609998



Sign in to add a comment

Blimp engine metrics reporting

Reported by jessi...@chromium.org, Mar 7 2016

Issue description


Currently there is no way of recording or reporting metrics for the Blimp engine.

To collect metrics for the Blimp engine in development two things are required. First, for metrics recording and reporting to be enabled on the Blimp engine.  Second, for the metrics logging to flag Blimp engine reports so they can be filtered from other linux metrics reports. These code behavior changes are currently kept between a single build arg, but are controlled via separate defines checks.

These changes will allow metrics to be collected on development instances of Blimp and viewed separately from Linux builds.

Owner: jessicag@chromium.org

Design doc: http://go/blimp_v05_metrics
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab7a08b61e58d1a50565cb892f3402cebafbcf16

commit ab7a08b61e58d1a50565cb892f3402cebafbcf16
Author: jessicag <jessicag@chromium.org>
Date: Fri Mar 11 22:34:49 2016

Add support for Blimp engine metrics reporting in development.

Currently there is no way of recording or reporting metrics for the Blimp engine.

To collect metrics for the Blimp engine in development two things are required. First, for metrics recording and reporting to be enabled on the Blimp engine.  Second, for the metrics logging to flag Blimp engine reports so they can be filtered from other linux metrics reports. These code behavior changes are currently kept between a single build arg, but are controlled via separate defines checks.

These changes will allow metrics to be collected on development instances of Blimp and viewed separately from Linux builds.

BUG= 592757 

Review URL: https://codereview.chromium.org/1765293002

Cr-Commit-Position: refs/heads/master@{#380760}

[modify] https://crrev.com/ab7a08b61e58d1a50565cb892f3402cebafbcf16/build/args/blimp_engine.gn
[modify] https://crrev.com/ab7a08b61e58d1a50565cb892f3402cebafbcf16/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/ab7a08b61e58d1a50565cb892f3402cebafbcf16/components/metrics/BUILD.gn
[modify] https://crrev.com/ab7a08b61e58d1a50565cb892f3402cebafbcf16/components/metrics/metrics_log.cc

Status: Fixed (was: Assigned)
Status: Started (was: Fixed)
Blimp results are not seen in UMA.  Investigating.
Components: Mobile>Blimp>Engine
Labels: -Proj-Blimp
Blockedon: 601155
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b891cd667f263782a6f97466e264de3e729d3bc0

commit b891cd667f263782a6f97466e264de3e729d3bc0
Author: jessicag <jessicag@chromium.org>
Date: Fri Apr 22 23:16:06 2016

Create a PrefStore in support of Blimp metrics collection.

A light-weight memory-backed perfstore implementation. Needed for MetricService support. Used to hold logs until upload.

Moving the existing store for android webview into a shared space under components/pref and adding tests.

BUG= 592757 , 604955 

Review URL: https://codereview.chromium.org/1881253003

Cr-Commit-Position: refs/heads/master@{#389291}

[modify] https://crrev.com/b891cd667f263782a6f97466e264de3e729d3bc0/android_webview/BUILD.gn
[modify] https://crrev.com/b891cd667f263782a6f97466e264de3e729d3bc0/android_webview/android_webview.gyp
[modify] https://crrev.com/b891cd667f263782a6f97466e264de3e729d3bc0/android_webview/browser/aw_browser_context.cc
[delete] https://crrev.com/ff03713022563711d6ed3d5e15a43decfaf867f4/android_webview/browser/aw_pref_store.cc
[modify] https://crrev.com/b891cd667f263782a6f97466e264de3e729d3bc0/android_webview/native/aw_autofill_client.cc
[modify] https://crrev.com/b891cd667f263782a6f97466e264de3e729d3bc0/components/prefs/BUILD.gn
[add] https://crrev.com/b891cd667f263782a6f97466e264de3e729d3bc0/components/prefs/in_memory_pref_store.cc
[rename] https://crrev.com/b891cd667f263782a6f97466e264de3e729d3bc0/components/prefs/in_memory_pref_store.h
[add] https://crrev.com/b891cd667f263782a6f97466e264de3e729d3bc0/components/prefs/in_memory_pref_store_unittest.cc
[modify] https://crrev.com/b891cd667f263782a6f97466e264de3e729d3bc0/components/prefs/prefs.gyp

Project Member

Comment 8 by bugdroid1@chromium.org, May 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb3bd1e8780cdd8d87ceb617a5b804607ed9098a

commit cb3bd1e8780cdd8d87ceb617a5b804607ed9098a
Author: jessicag <jessicag@chromium.org>
Date: Wed May 04 08:46:12 2016

Revert of Create and integrate a metrics service client into Blimp engine. (patchset #13 id:240001 of https://codereview.chromium.org/1885673003/ )

Reason for revert:
Detected engine crash.  Looks like a PerfService lifetime issue.

Original issue's description:
> Create and integrate a metrics service client into Blimp engine.
>
> This will allow Blimp to collect and upload metrics to aid in
> development.
>
> BUG= 592757 
>
> Committed: https://crrev.com/0be9daea216b9144830da20bcb3e2a56591207e6
> Cr-Commit-Position: refs/heads/master@{#391360}

TBR=wez@chromium.org,battre@chromium.org,bauerb@chromium.org,asvitkine@chromium.org,kmarshall@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 592757 

Review-Url: https://codereview.chromium.org/1948733003
Cr-Commit-Position: refs/heads/master@{#391462}

[modify] https://crrev.com/cb3bd1e8780cdd8d87ceb617a5b804607ed9098a/blimp/engine/BUILD.gn
[modify] https://crrev.com/cb3bd1e8780cdd8d87ceb617a5b804607ed9098a/blimp/engine/DEPS
[delete] https://crrev.com/c8f527056c4653134fc76f01900b5f053adc8b05/blimp/engine/app/blimp_metrics_service_client.cc
[delete] https://crrev.com/c8f527056c4653134fc76f01900b5f053adc8b05/blimp/engine/app/blimp_metrics_service_client.h
[delete] https://crrev.com/c8f527056c4653134fc76f01900b5f053adc8b05/blimp/engine/app/blimp_metrics_service_client_unittest.cc
[modify] https://crrev.com/cb3bd1e8780cdd8d87ceb617a5b804607ed9098a/blimp/engine/common/blimp_browser_context.cc
[modify] https://crrev.com/cb3bd1e8780cdd8d87ceb617a5b804607ed9098a/blimp/engine/common/blimp_browser_context.h

Blockedon: 609998
Project Member

Comment 10 by bugdroid1@chromium.org, May 11 2016

Project Member

Comment 11 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cda2a8fb0bc180272cd1be30d1213f83a64a3e8

commit 4cda2a8fb0bc180272cd1be30d1213f83a64a3e8
Author: jessicag <jessicag@chromium.org>
Date: Thu May 12 18:32:22 2016

Clean up unused metrics flag from chrome/browser.
I added this flag in https://codereview.chromium.org/1765293002 understanding
chrome/browser was used by Blimp engine, but it is not.

This logic is handled in blimp/engine instead (https://codereview.chromium.org/1945393002).

I am cleaning up the (noop) changes. No behavior change is expected from removing this unused flag.

BUG= 592757 

Review-Url: https://codereview.chromium.org/1964733002
Cr-Commit-Position: refs/heads/master@{#393312}

[modify] https://crrev.com/4cda2a8fb0bc180272cd1be30d1213f83a64a3e8/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/4cda2a8fb0bc180272cd1be30d1213f83a64a3e8/components/metrics/BUILD.gn

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/117048d26a9409d12988e63985ad9c6181f4838d

commit 117048d26a9409d12988e63985ad9c6181f4838d
Author: jessicag <jessicag@chromium.org>
Date: Mon Jun 06 22:59:07 2016

Add user agent to System Context Getter as suggested by metrics team.

Currently the user agent is set to empty string which results in the
upload being ignored by the metrics service.

Setting this value will allow for processing and display of metrics
for Blimp.

BUG= 592757 

Review-Url: https://codereview.chromium.org/2041933002
Cr-Commit-Position: refs/heads/master@{#398155}

[modify] https://crrev.com/117048d26a9409d12988e63985ad9c6181f4838d/blimp/engine/app/blimp_system_url_request_context_getter.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf31b77907bb3968b51a6c44c421dcca671adbbc

commit cf31b77907bb3968b51a6c44c421dcca671adbbc
Author: jessicag <jessicag@chromium.org>
Date: Thu Jul 14 01:58:15 2016

Updating GetChannel in BlimpMetricsServiceClient so metrics will display properly in tools.

Currently the metrics can only be viewed in a subset of tool displays due to the channel field having a value of CHANNEL_UNKNOWN. Metrics with UNKNOWN channel are filtered by default as unofficial builds.

BUG= 592757 

Review-Url: https://codereview.chromium.org/2142363002
Cr-Commit-Position: refs/heads/master@{#405398}

[modify] https://crrev.com/cf31b77907bb3968b51a6c44c421dcca671adbbc/blimp/engine/app/blimp_metrics_service_client.cc

Status: Fixed (was: Started)
Labels: Archive-Blimp

Sign in to add a comment