New issue
Advanced search Search tips

Issue 592750 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Feature

Blocking:
issue 62400



Sign in to add a comment

Pdf XFA: No caret in input boxes

Project Member Reported by aval...@chromium.org, Mar 7 2016

Issue description

Version: 7c1c27414ff9e29a88fec8f717b4c157363bfae6


What steps will reproduce the problem?
(1) Try to fill an XFA form such as http://www.cic.gc.ca/english/pdf/kits/forms/IMM5257E.pdf
(2) In the full name field, click to type

What is the expected output? What do you see instead?
A caret that blinks to show where my keystrokes will insert text.

Instead, magic. Letters appear somewhere, but unless I just clicked in the box, I had no idea where I'm inserting text.

Please use labels and text to provide additional information.



 
Cc: thestig@chromium.org dsinclair@chromium.org tsepez@chromium.org
Components: Internals>Plugins>PDF
Labels: OS-Linux
Blocking: 62400
Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 19 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: rharrison@chromium.org
Status: Assigned (was: Untriaged)
Owner: hnakashima@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/bfeab62b37a701dc82f180e49d26c602f96f96f9

commit bfeab62b37a701dc82f180e49d26c602f96f96f9
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Tue Feb 06 21:36:45 2018

Fix caret not appearing in XFA Edits.

This makes the caret appear (again?), blink, and fixes its positioning
to be a little spaced from the last character.

Known issue: when the edit is empty, the caret is not necessarily
aligned with where the text will be.

Bug:  chromium:592750 
Change-Id: I950b0ea236db8855c6ed50f48ec1935d97e6ccf8
Reviewed-on: https://pdfium-review.googlesource.com/25451
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>

[modify] https://crrev.com/bfeab62b37a701dc82f180e49d26c602f96f96f9/xfa/fwl/cfwl_timer.h
[modify] https://crrev.com/bfeab62b37a701dc82f180e49d26c602f96f96f9/fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.h
[modify] https://crrev.com/bfeab62b37a701dc82f180e49d26c602f96f96f9/xfa/fwl/cfwl_timer.cpp
[modify] https://crrev.com/bfeab62b37a701dc82f180e49d26c602f96f96f9/xfa/fwl/cfwl_edit.cpp
[modify] https://crrev.com/bfeab62b37a701dc82f180e49d26c602f96f96f9/xfa/fwl/cfwl_caret.cpp
[modify] https://crrev.com/bfeab62b37a701dc82f180e49d26c602f96f96f9/DEPS
[modify] https://crrev.com/bfeab62b37a701dc82f180e49d26c602f96f96f9/xfa/fwl/ifwl_adaptertimermgr.h
[modify] https://crrev.com/bfeab62b37a701dc82f180e49d26c602f96f96f9/xfa/fde/cfde_texteditengine.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/2496f8e3f3cb1cbfffd664c9b5d7983dc192887b

commit 2496f8e3f3cb1cbfffd664c9b5d7983dc192887b
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Wed Feb 07 20:18:15 2018

Restore assert when GetCharacterInfo is called on an empty edit.

CFWL_Edit::UpdateCursorRect now checks if the edit is empty before
getting the caret position.

Bug:  chromium:592750 
Change-Id: I792e90537741a78141fa084a646380bfe7ce4637
Reviewed-on: https://pdfium-review.googlesource.com/25910
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>

[modify] https://crrev.com/2496f8e3f3cb1cbfffd664c9b5d7983dc192887b/xfa/fde/cfde_texteditengine.cpp
[modify] https://crrev.com/2496f8e3f3cb1cbfffd664c9b5d7983dc192887b/xfa/fwl/cfwl_edit.cpp

Status: Fixed (was: Assigned)
Cc: rharrison@chromium.org
 Issue pdfium:752  has been merged into this issue.

Sign in to add a comment