NCLButtonDown tests flaky in views_unittest |
|
Issue descriptionIn the past week I've seen these two tests flake a lot on the win_chromium_x64_rel_ng trybot: WidgetTest.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest WidgetTest.DestroyInSysCommandNCLButtonDownOnCaption See: https://build.chromium.org/f/chromium/flakiness/
,
Mar 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da9b02d4f7b5c2ad53e6e0573edaf8f48c892ba3 commit da9b02d4f7b5c2ad53e6e0573edaf8f48c892ba3 Author: ananta <ananta@chromium.org> Date: Wed Mar 09 00:26:49 2016 Convert the flaky SysCommand widget tests into interactive ui tests. It looks like these tests are flaky due to window messages not firing as expected. Hopefully with these tests being converted to interactive ui tests we should not have flakiness due to activation and related problems. Tests being converted are as below:- 1. DestroyInSysCommandNCLButtonDownOnCaption 2. SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest BUG=592742 Review URL: https://codereview.chromium.org/1776763002 Cr-Commit-Position: refs/heads/master@{#379991} [modify] https://crrev.com/da9b02d4f7b5c2ad53e6e0573edaf8f48c892ba3/ui/views/widget/widget_interactive_uitest.cc [modify] https://crrev.com/da9b02d4f7b5c2ad53e6e0573edaf8f48c892ba3/ui/views/widget/widget_unittest.cc
,
Mar 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/185cd4741f24c35ee5eba163195752cef5856db8 commit 185cd4741f24c35ee5eba163195752cef5856db8 Author: tsergeant <tsergeant@chromium.org> Date: Wed Mar 09 03:22:08 2016 Revert of Convert the flaky SysCommand widget tests into interactive ui tests. (patchset #1 id:1 of https://codereview.chromium.org/1776763002/ ) Reason for revert: The test WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest is failing in interactive_ui_tests on Windows-7-SP1. See: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/46677 Original issue's description: > Convert the flaky SysCommand widget tests into interactive ui tests. > > It looks like these tests are flaky due to window messages not firing as expected. Hopefully > with these tests being converted to interactive ui tests we should not have flakiness due to activation > and related problems. > > Tests being converted are as below:- > 1. DestroyInSysCommandNCLButtonDownOnCaption > 2. SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest > > BUG=592742 > > Committed: https://crrev.com/da9b02d4f7b5c2ad53e6e0573edaf8f48c892ba3 > Cr-Commit-Position: refs/heads/master@{#379991} TBR=sky@chromium.org,ananta@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=592742 Review URL: https://codereview.chromium.org/1774413002 Cr-Commit-Position: refs/heads/master@{#380050} [modify] https://crrev.com/185cd4741f24c35ee5eba163195752cef5856db8/ui/views/widget/widget_interactive_uitest.cc [modify] https://crrev.com/185cd4741f24c35ee5eba163195752cef5856db8/ui/views/widget/widget_unittest.cc
,
Mar 9 2016
Test failed across three consecutive runs: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/46679 https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/46678 https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/46677 Sample log output: Retrying 1 test (retry #1) Still waiting for the following processes to finish: "..\out\Debug\interactive_ui_tests.exe" --allow-file-access --gtest_also_run_disabled_tests --gtest_filter=WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outr3b3gk\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir7108_21226\d7108_23123" Still waiting for the following processes to finish: "..\out\Debug\interactive_ui_tests.exe" --allow-file-access --gtest_also_run_disabled_tests --gtest_filter=WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outr3b3gk\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir7108_21226\d7108_23123" Still waiting for the following processes to finish: "..\out\Debug\interactive_ui_tests.exe" --allow-file-access --gtest_also_run_disabled_tests --gtest_filter=WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outr3b3gk\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir7108_21226\d7108_23123" [ RUN ] WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest [145/145] WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest (TIMED OUT) Retrying 1 test (retry #2) Still waiting for the following processes to finish: "..\out\Debug\interactive_ui_tests.exe" --allow-file-access --gtest_also_run_disabled_tests --gtest_filter=WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outr3b3gk\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir7108_21226\d7108_22668" Still waiting for the following processes to finish: "..\out\Debug\interactive_ui_tests.exe" --allow-file-access --gtest_also_run_disabled_tests --gtest_filter=WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outr3b3gk\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir7108_21226\d7108_22668" Still waiting for the following processes to finish: "..\out\Debug\interactive_ui_tests.exe" --allow-file-access --gtest_also_run_disabled_tests --gtest_filter=WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outr3b3gk\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir7108_21226\d7108_22668" [ RUN ] WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest [146/146] WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest (TIMED OUT) Retrying 1 test (retry #3) Still waiting for the following processes to finish: "..\out\Debug\interactive_ui_tests.exe" --allow-file-access --gtest_also_run_disabled_tests --gtest_filter=WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outr3b3gk\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir7108_21226\d7108_19247" Still waiting for the following processes to finish: "..\out\Debug\interactive_ui_tests.exe" --allow-file-access --gtest_also_run_disabled_tests --gtest_filter=WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outr3b3gk\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir7108_21226\d7108_19247" Still waiting for the following processes to finish: "..\out\Debug\interactive_ui_tests.exe" --allow-file-access --gtest_also_run_disabled_tests --gtest_filter=WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outr3b3gk\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir7108_21226\d7108_19247" [ RUN ] WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest [147/147] WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest (TIMED OUT) 1 test timed out: WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest (c:\b\build\slave\win_builder__dbg_\build\src\ui\views\widget\widget_interactive_uitest.cc:891)
,
Aug 21
|
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, Mar 7 2016