New issue
Advanced search Search tips

Issue 592741 link

Starred by 1 user
Status: Verified
Owner:
est...@chromium.org
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Ash frame header color is incorrect in non-material

Project Member Reported by tdander...@chromium.org, Mar 7 2016 
Version: 51.0.2671.0 (possibly also present in M-50)
OS: Chrome OS

With top chrome MD set to non-material (--top-chrome-md=non-material in about:flags), the color of the Ash frame header is incorrect (shows up as white / transparent). See the attached screenshots.
ash-non-material.png
403 KB View Download
ash-non-material-otr.png
349 KB View Download

Comment 1 by tdander...@chromium.org, Mar 7 2016

Owner: est...@chromium.org
Status: Assigned (was: Untriaged)
Evan, I think you recently changed how the header painting works so this is probably from one of your changes - punt back to me if that isn't the case and I will have a look.

Note we should see when the offending change landed and merge back into M-50 if needed.

Comment 2 by est...@chromium.org, Mar 9 2016

Status: Started (was: Assigned)
I don't think this is present in m50 because it regressed in crrev.com/378648
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4380cf09954439aa280f7bce3104eff1e53e526

commit d4380cf09954439aa280f7bce3104eff1e53e526
Author: estade <estade@chromium.org>
Date: Thu Mar 10 03:06:58 2016

CrOS - in pre-MD mode, paint frame correctly

This regressed in c26c0f3e2df970d98 which landed after the m50 branch,
so this fix is mostly academic. But the change is small and if for some
reason we need to revert to pre-MD on CrOS 51, this change will be
necessary.

BUG= 592741 

Review URL: https://codereview.chromium.org/1774423002

Cr-Commit-Position: refs/heads/master@{#380318}

[modify] https://crrev.com/d4380cf09954439aa280f7bce3104eff1e53e526/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc

Comment 4 by est...@chromium.org, Mar 15 2016

Status: Fixed (was: Started)

Comment 5 by rookrishna@chromium.org, Apr 25 2016

Status: Verified (was: Fixed)
►

Sign in to add a comment