New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 592732 link

Starred by 2 users
Status: Fixed
Owner:
█ avayvod@chromium.org
Last visit > 30 days ago
Closed: Apr 2016
Cc:
█ avayvod@chromium.org
mlamouri@chromium.org
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Presentation API] Implement PresentationConnection onConnected/onClosed/onTerminated event handlers in Android

Project Member Reported by zqzh...@chromium.org, Mar 7 2016 
A recent change on presentation api event handlers has landed (
https://bugs.chromium.org/p/chromium/issues/detail?id=574233).

We need to update Android code to match the behavior.
Specifically, NotifyPresentationConnectionClose and NotifyPresentationConnectionStateChange need to be called properly when the connection state has changed.

Comment 1 by mlamouri@chromium.org, Mar 18 2016

Cc: mlamouri@chromium.org

Comment 2 by mlamouri@chromium.org, Apr 12 2016

Labels: M-51
Owner: avayvod@chromium.org
Status: Assigned (was: Available)
Anton, could you have a look and see if we can port this to M51 if it is simple enough?

Comment 3 by avayvod@chromium.org, Apr 12 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd75c6ecf3b206cab118e8f38831101fb44fcc22

commit dd75c6ecf3b206cab118e8f38831101fb44fcc22
Author: avayvod <avayvod@chromium.org>
Date: Mon Apr 18 12:16:26 2016

[Android,MediaRouter,Cast] implement onterminate and onclose.

BUG= 592732 
TEST=e2e tests + MR instrumentation tests

Review URL: https://codereview.chromium.org/1883423002

Cr-Commit-Position: refs/heads/master@{#387894}

[modify] https://crrev.com/dd75c6ecf3b206cab118e8f38831101fb44fcc22/chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java
[modify] https://crrev.com/dd75c6ecf3b206cab118e8f38831101fb44fcc22/chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaRouteManager.java
[modify] https://crrev.com/dd75c6ecf3b206cab118e8f38831101fb44fcc22/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java
[modify] https://crrev.com/dd75c6ecf3b206cab118e8f38831101fb44fcc22/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java
[modify] https://crrev.com/dd75c6ecf3b206cab118e8f38831101fb44fcc22/chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MediaRouterIntegrationTest.java
[modify] https://crrev.com/dd75c6ecf3b206cab118e8f38831101fb44fcc22/chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MockMediaRouteProvider.java
[modify] https://crrev.com/dd75c6ecf3b206cab118e8f38831101fb44fcc22/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/dd75c6ecf3b206cab118e8f38831101fb44fcc22/chrome/browser/media/android/router/media_router_android.h

Comment 5 by avayvod@chromium.org, Apr 18 2016

Labels: -M-51 M-52
Don't think we need to merge this to M-51.

Comment 6 by avayvod@chromium.org, Apr 18 2016

Status: Fixed (was: Started)
►

Sign in to add a comment