Graphical glitch when multiple infobars are shown in material design UI |
||||||||||
Issue description
Version: ToT (523b8522 refs/heads/master@{#379597})
OS: Linux (Ubuntu trusty)
What steps will reproduce the problem?
(1) Run "chrome --no-sandbox" (any switch which triggers the "unsupported flag" notice works).
(2) Observe that the arrow on the second infobar shown is invisible.
What is the expected output? What do you see instead?
See attached screenshot. I'd expect both arrows to be drawn, like they are in the non-material Aura UI.
,
Mar 7 2016
This probably applies to m50 cros as well. Terry, do you not think it's worth trying to fix on m50 branch?
,
Mar 8 2016
I don't think it would be very common whatsoever for the end user to get into this situation (correct me if I'm wrong on that), but it is still a regression and would be nice to have it fixed in M-50.
,
Mar 8 2016
yea, probably not common. The --no-sandbox flag is a nice way to repro but in general I'm not sure how common multiple bars are.
,
Mar 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/966e15221d7c60c7922d94af047a6663cb175c1e commit 966e15221d7c60c7922d94af047a6663cb175c1e Author: estade <estade@chromium.org> Date: Tue Mar 15 18:48:11 2016 [md] Give each infobar its own layer. This is necessary so latter bars can draw their arrow above the previous bar. This is similar to crbug.com/589771 , the fix for which only worked for the first infobar. This also fixes hit testing which was broken when there was a floating bookmark bar below the infobar. BUG= 592727 , 593640 Review URL: https://codereview.chromium.org/1767363002 Cr-Commit-Position: refs/heads/master@{#381267} [modify] https://crrev.com/966e15221d7c60c7922d94af047a6663cb175c1e/chrome/browser/ui/views/infobars/infobar_container_view.cc [modify] https://crrev.com/966e15221d7c60c7922d94af047a6663cb175c1e/chrome/browser/ui/views/infobars/infobar_view.cc [modify] https://crrev.com/966e15221d7c60c7922d94af047a6663cb175c1e/chrome/browser/ui/views/infobars/infobar_view.h
,
Mar 15 2016
Issue 594968 has been merged into this issue.
,
Mar 15 2016
,
Mar 15 2016
because the fix addresses this and also bug 593640 , both of which would be annoying to see in stable, I plan to request a merge.
,
Mar 18 2016
,
Mar 18 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 18 2016
Please try to merge your change to M50 branch 2661 asap as we're getting closer to M50 beta candidate cut for next week. Thank you.
,
Mar 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4ee21f5b2c49c57ca897b85c1ed67b375ad2603 commit f4ee21f5b2c49c57ca897b85c1ed67b375ad2603 Author: Evan Stade <estade@chromium.org> Date: Fri Mar 18 18:35:57 2016 [md] Give each infobar its own layer. This is necessary so latter bars can draw their arrow above the previous bar. This is similar to crbug.com/589771 , the fix for which only worked for the first infobar. This also fixes hit testing which was broken when there was a floating bookmark bar below the infobar. BUG= 592727 , 593640 Review URL: https://codereview.chromium.org/1767363002 Cr-Commit-Position: refs/heads/master@{#381267} (cherry picked from commit 966e15221d7c60c7922d94af047a6663cb175c1e) Review URL: https://codereview.chromium.org/1817573002 . Cr-Commit-Position: refs/branch-heads/2661@{#283} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/f4ee21f5b2c49c57ca897b85c1ed67b375ad2603/chrome/browser/ui/views/infobars/infobar_container_view.cc [modify] https://crrev.com/f4ee21f5b2c49c57ca897b85c1ed67b375ad2603/chrome/browser/ui/views/infobars/infobar_view.cc [modify] https://crrev.com/f4ee21f5b2c49c57ca897b85c1ed67b375ad2603/chrome/browser/ui/views/infobars/infobar_view.h
,
Mar 22 2016
Verified the issue on windows 7, Linux Ubuntu 14.04 using chrome version 50.0.2661.48.able to see the arrow of second infobar. Please find the attached screen shot for the same. Adding TE-Verified label.
,
Mar 22 2016
This should be verified on Chrome OS beta-channel once the change makes it into the next beta release. Evan, what's a real scenario where we'd see two infobars at once as an end user (i.e., without being able to pass --no-sandbox on the command line)?
,
Feb 21 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by tdander...@chromium.org
, Mar 7 2016Labels: M-51
Owner: est...@chromium.org
Status: Assigned (was: Untriaged)