New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 592727 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Graphical glitch when multiple infobars are shown in material design UI

Project Member Reported by jbroman@chromium.org, Mar 7 2016

Issue description

Version: ToT (523b8522 refs/heads/master@{#379597})
OS: Linux (Ubuntu trusty)

What steps will reproduce the problem?
(1) Run "chrome --no-sandbox" (any switch which triggers the "unsupported flag" notice works).
(2) Observe that the arrow on the second infobar shown is invisible.

What is the expected output? What do you see instead?
See attached screenshot. I'd expect both arrows to be drawn, like they are in the non-material Aura UI.
 
infobarglitch.png
14.0 KB View Download
Cc: tdander...@chromium.org
Labels: M-51
Owner: est...@chromium.org
Status: Assigned (was: Untriaged)
This probably applies to m50 cros as well.  Terry, do you not think it's worth trying to fix on m50 branch?
Labels: -Type-Bug -M-51 M-50 OS-Chrome OS-Windows Type-Bug-Regression
I don't think it would be very common whatsoever for the end user to get into this situation (correct me if I'm wrong on that), but it is still a regression and would be nice to have it fixed in M-50.
yea, probably not common. The --no-sandbox flag is a nice way to repro but in general I'm not sure how common multiple bars are.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/966e15221d7c60c7922d94af047a6663cb175c1e

commit 966e15221d7c60c7922d94af047a6663cb175c1e
Author: estade <estade@chromium.org>
Date: Tue Mar 15 18:48:11 2016

[md] Give each infobar its own layer.

This is necessary so latter bars can draw their arrow above the previous bar.
This is similar to  crbug.com/589771  , the fix for which only worked for the first infobar.

This also fixes hit testing which was broken when there was a floating bookmark bar below the infobar.

BUG= 592727 ,  593640 

Review URL: https://codereview.chromium.org/1767363002

Cr-Commit-Position: refs/heads/master@{#381267}

[modify] https://crrev.com/966e15221d7c60c7922d94af047a6663cb175c1e/chrome/browser/ui/views/infobars/infobar_container_view.cc
[modify] https://crrev.com/966e15221d7c60c7922d94af047a6663cb175c1e/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/966e15221d7c60c7922d94af047a6663cb175c1e/chrome/browser/ui/views/infobars/infobar_view.h

Comment 6 by est...@chromium.org, Mar 15 2016

Cc: nyerramilli@chromium.org est...@chromium.org ranjitkan@chromium.org
 Issue 594968  has been merged into this issue.

Comment 7 by est...@chromium.org, Mar 15 2016

Status: Fixed (was: Assigned)

Comment 8 by est...@chromium.org, Mar 15 2016

Labels: ReleaseBlock-Stable
because the fix addresses this and also  bug 593640 , both of which would be annoying to see in stable, I plan to request a merge.

Comment 9 by est...@chromium.org, Mar 18 2016

Labels: Merge-Request-50

Comment 10 by tin...@google.com, Mar 18 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Please try to merge your change to M50 branch 2661 asap as we're getting closer to M50 beta candidate cut for next week. Thank you.
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 18 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4ee21f5b2c49c57ca897b85c1ed67b375ad2603

commit f4ee21f5b2c49c57ca897b85c1ed67b375ad2603
Author: Evan Stade <estade@chromium.org>
Date: Fri Mar 18 18:35:57 2016

[md] Give each infobar its own layer.

This is necessary so latter bars can draw their arrow above the previous bar.
This is similar to  crbug.com/589771  , the fix for which only worked for the first infobar.

This also fixes hit testing which was broken when there was a floating bookmark bar below the infobar.

BUG= 592727 ,  593640 

Review URL: https://codereview.chromium.org/1767363002

Cr-Commit-Position: refs/heads/master@{#381267}
(cherry picked from commit 966e15221d7c60c7922d94af047a6663cb175c1e)

Review URL: https://codereview.chromium.org/1817573002 .

Cr-Commit-Position: refs/branch-heads/2661@{#283}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/f4ee21f5b2c49c57ca897b85c1ed67b375ad2603/chrome/browser/ui/views/infobars/infobar_container_view.cc
[modify] https://crrev.com/f4ee21f5b2c49c57ca897b85c1ed67b375ad2603/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/f4ee21f5b2c49c57ca897b85c1ed67b375ad2603/chrome/browser/ui/views/infobars/infobar_view.h

Labels: TE-Verified-M50 TE-Verified-50.0.2661.48
Verified the issue on windows 7, Linux Ubuntu 14.04 using chrome version 50.0.2661.48.able to see the arrow of second infobar. Please find the attached screen shot for the same.

Adding TE-Verified label.
592727.png
109 KB View Download
This should be verified on Chrome OS beta-channel once the change makes it into the next beta release. Evan, what's a real scenario where we'd see two infobars at once as an end user (i.e., without being able to pass --no-sandbox on the command line)?
Status: Verified (was: Fixed)

Sign in to add a comment