[Media Router] Window re-focus enters filter view when search input is selected. |
|||||||
Issue descriptionVersion: OS: Ubuntu 14.04 What steps will reproduce the problem? 1. Open media router cast dialog. 2. Click the search button. 3. Press Escape. 4. Focus another window. 5. Return to the media router cast dialog. 6. Dialog will re-enter the filter view. What is the expected output? What do you see instead? The expected output is that the dialog stays on the sink list when re-focusing the window. Instead, it transitions to the filter view. Please use labels and text to provide additional information.
,
Mar 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87227cdfcad72f70bc803deded83e5f638199de0 commit 87227cdfcad72f70bc803deded83e5f638199de0 Author: btolsch <btolsch@chromium.org> Date: Wed Mar 09 20:02:52 2016 [Media Router] Fixed window refocus problem for filter view input. This change fixes the following case: 1. The user enters filter view. 2. The user presses the Escape key which leaves filter view but keeps keyboard focus on the search input. 3. The user focuses another window and then returns to the media router dialog. 4. The dialog automatically switches to filter view. The dialog should not be triggered to switch to filter view only by changing window focus. BUG= 592723 R=apacible@chromium.org Review URL: https://codereview.chromium.org/1772813002 Cr-Commit-Position: refs/heads/master@{#380182} [modify] https://crrev.com/87227cdfcad72f70bc803deded83e5f638199de0/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
,
Mar 9 2016
,
Apr 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67884ed3d9b680286ca9fa2fbc372027cd2b5d0d commit 67884ed3d9b680286ca9fa2fbc372027cd2b5d0d Author: btolsch <btolsch@chromium.org> Date: Tue Apr 19 09:43:34 2016 [Media Router WebUI] Simplify search input focus handlers. This change removes some unnecessary variables and focus handlers for the window and search input. BUG= 592723 R=apacible@chromium.org Review URL: https://codereview.chromium.org/1901893002 Cr-Commit-Position: refs/heads/master@{#388172} [modify] https://crrev.com/67884ed3d9b680286ca9fa2fbc372027cd2b5d0d/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
,
May 24 2016
Saw this today on ToT. Version: 53.0.2748.0 Suspecting https://chromium.googlesource.com/chromium/src.git/+/4d46c69 as it possibly prevents focus handlers from being set correctly for the search element.
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5e7577ef96ee5fa24c8952e649312dc5427aa42 commit e5e7577ef96ee5fa24c8952e649312dc5427aa42 Author: btolsch <btolsch@chromium.org> Date: Wed May 25 01:55:18 2016 [Media Router WebUI] Fix search focus handlers when search is enabled This change corrects the point of setting the search focus handlers to be after search first becomes enabled. Previously it was set in ready(), but since disabling search by default, the handlers weren't correctly updated. BUG= 592723 R=apacible@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2012593002 Cr-Commit-Position: refs/heads/master@{#395774} [modify] https://crrev.com/e5e7577ef96ee5fa24c8952e649312dc5427aa42/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
,
May 26 2016
,
May 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89251be1f810dbf03e2a4a2865e20d982c0e6d05 commit 89251be1f810dbf03e2a4a2865e20d982c0e6d05 Author: btolsch <btolsch@chromium.org> Date: Fri May 27 07:23:15 2016 [Media Router WebUI] Add test for search focus when switching windows This change adds a browser test for the following case: The user selects the search input and then presses the Escape key. The dialog is now in the sink list view but keyboard focus is still on the search input. The user switches to another window and then back to the dialog. The container should remain in the sink list view and should not transition to the filter view, even though a focus event is fired on the search input. BUG= 592723 R=apacible@chromium.org Review-Url: https://codereview.chromium.org/2016193002 Cr-Commit-Position: refs/heads/master@{#396415} [modify] https://crrev.com/89251be1f810dbf03e2a4a2865e20d982c0e6d05/chrome/test/data/webui/media_router/media_router_container_filter_tests.js
,
Jun 1 2016
The most recent change was in response to a change for crbug.com/612969 , which was merged into M52.
,
Jun 1 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05b6856f7e99a0cd796298b6ab22bfb2b34734ac commit 05b6856f7e99a0cd796298b6ab22bfb2b34734ac Author: btolsch <btolsch@chromium.org> Date: Wed Jun 01 22:40:17 2016 [Media Router WebUI] Fix search focus handlers when search is enabled This change corrects the point of setting the search focus handlers to be after search first becomes enabled. Previously it was set in ready(), but since disabling search by default, the handlers weren't correctly updated. BUG= 592723 R=apacible@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2012593002 Cr-Commit-Position: refs/heads/master@{#395774} (cherry picked from commit e5e7577ef96ee5fa24c8952e649312dc5427aa42) Review-Url: https://codereview.chromium.org/2033473002 Cr-Commit-Position: refs/branch-heads/2743@{#178} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/05b6856f7e99a0cd796298b6ab22bfb2b34734ac/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by btolsch@chromium.org
, Mar 7 2016