Strip Content-Encoding response headers in CronetHttpURLConnection |
|||||
Issue descriptionCronet decompresses response body before returning it to consumers, we should strip Content-Encoding headers so that consumers wouldn't try to decompress for a second time.
,
Mar 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cee2840c4bcd51313e33f0ab215413f9a8f70480 commit cee2840c4bcd51313e33f0ab215413f9a8f70480 Author: xunjieli <xunjieli@chromium.org> Date: Tue Mar 08 20:43:59 2016 Strip content-encoding response header from CronetHttpURLConnection response. Cronet decompresses response body before returning it to consumers, we should strip Content-Encoding headers so that consumers wouldn't try to decompress for a second time. BUG= 592700 Review URL: https://codereview.chromium.org/1779473002 Cr-Commit-Position: refs/heads/master@{#379903} [modify] https://crrev.com/cee2840c4bcd51313e33f0ab215413f9a8f70480/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java [add] https://crrev.com/cee2840c4bcd51313e33f0ab215413f9a8f70480/components/cronet/android/test/assets/test/gzipped.html [add] https://crrev.com/cee2840c4bcd51313e33f0ab215413f9a8f70480/components/cronet/android/test/assets/test/gzipped.html.mock-http-headers [modify] https://crrev.com/cee2840c4bcd51313e33f0ab215413f9a8f70480/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
,
Mar 8 2016
,
Mar 14 2016
,
Mar 14 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 14 2016
Helen, do we need it in M50? If we do, do you want me to merge it into 2661?
,
Mar 14 2016
Yes, please. That'll be great. Thanks!
,
Mar 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d25d5a281c748d5f9375972ecddd4306082386ff commit d25d5a281c748d5f9375972ecddd4306082386ff Author: Misha Efimov <mef@google.com> Date: Mon Mar 14 20:01:16 2016 Strip content-encoding response header from CronetHttpURLConnection response. Cronet decompresses response body before returning it to consumers, we should strip Content-Encoding headers so that consumers wouldn't try to decompress for a second time. BUG= 592700 Review URL: https://codereview.chromium.org/1779473002 Cr-Commit-Position: refs/heads/master@{#379903} (cherry picked from commit cee2840c4bcd51313e33f0ab215413f9a8f70480) R=xunjieli@chromium.org Review URL: https://codereview.chromium.org/1801993002 . Cr-Commit-Position: refs/branch-heads/2661@{#220} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/d25d5a281c748d5f9375972ecddd4306082386ff/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java [add] https://crrev.com/d25d5a281c748d5f9375972ecddd4306082386ff/components/cronet/android/test/assets/test/gzipped.html [add] https://crrev.com/d25d5a281c748d5f9375972ecddd4306082386ff/components/cronet/android/test/assets/test/gzipped.html.mock-http-headers [modify] https://crrev.com/d25d5a281c748d5f9375972ecddd4306082386ff/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by xunji...@chromium.org
, Mar 8 2016