Issue metadata
Sign in to add a comment
|
Bisect should early out if it reproduces a failure for return code bisects. |
||||||||||||||||||||||||
Issue descriptionhttps://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1192 Might be reading this wrong, but I was trying to bisect on return code. I think the old script would early out as soon as any run failed if it was bisecting on return code, whereas this seems to continue and run every iteration.
,
Mar 9 2016
I think it makes sense to treat return code bisects specially, as long as we're assuming that at least one failure means it should be classified as "bad". But, if possible, it may be good to keep the logic/process for return-code and perf result bisects as similar/simple as possible. Anyone have any other thoughts about this?
,
Mar 16 2016
I feel this is a dup of 593055, because current bisect by default runs tests for 5 time for either of the cases (perf or return_code). If we fix 593055 for return_code then I don't think it will continue on failures. If you user specifies >1 repeat_count then bisect should continue even after the failure.
,
Mar 17 2016
,
Mar 17 2016
How about flakey failures? You'd still early out after reproducing just 1.
,
Feb 3 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by qyears...@chromium.org
, Mar 8 2016