New issue
Advanced search Search tips

Issue 592684 link

Starred by 1 user
Status: Verified
Owner: ----
Closed: Mar 2016
Cc:
dtseng@chromium.org
lpalmaro@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

ChromeVox Next: panel dropdown list of shortcuts still shows Classic shortcuts

Project Member Reported by kathrelk...@chromium.org, Mar 7 2016 
Version: M50+

What steps will reproduce the problem?
1. Enable ChromeVox
2. In the top left of the ChromeVox Panel, select the dropdown menu.
3. See lists of commands and their shortcuts.

What is the expected output? What do you see instead?
Expect these shortcuts to match the current state: Classic shortcuts for Compatibility mode, Next shortcuts for Next.

Instead, only Classic shortcuts are shown.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/936bb9cf6ce9bc8b0f97321197ed8eecb971354d

commit 936bb9cf6ce9bc8b0f97321197ed8eecb971354d
Author: dtseng <dtseng@chromium.org>
Date: Tue Mar 08 22:27:09 2016

Set keymap in prefs when switching modes in Next.

Previously, we were only setting the ChromeVoxKBHandler member (which was sufficient to get key events to trigger commands). However, the actual pref wasn't being set so ChromeVox's panel didn't pick up on it.

TEST=manual
BUG= 592684 

Review URL: https://codereview.chromium.org/1773003002

Cr-Commit-Position: refs/heads/master@{#379940}

[modify] https://crrev.com/936bb9cf6ce9bc8b0f97321197ed8eecb971354d/chrome/browser/resources/chromeos/chromevox/chromevox/background/prefs.js
[modify] https://crrev.com/936bb9cf6ce9bc8b0f97321197ed8eecb971354d/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Comment 2 by dtseng@chromium.org, Mar 8 2016

Status: fixed (was: Untriaged)

Comment 3 by pbath...@chromium.org, Mar 24 2016

Status: Verified (was: Fixed)
verified on 51.0.2689.0 / 8105.0.0
►

Sign in to add a comment