New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 592681 link

Starred by 0 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Gfx



Sign in to add a comment

gbmtest fails since 7995

Project Member Reported by ynovikov@chromium.org, Mar 7 2016

Issue description

Looks like my new checks in https://chromium-review.googlesource.com/318932 fail on some platforms. Will take a look.
 

Comment 1 by ihf@chromium.org, Mar 7 2016

Some boards pass. But for posteriority, looks like 2 failing cases:

enguarde_2.2GHz_4GB
03/03 00:45:11.864 DEBUG|        base_utils:0268| [stdout] CHECK failed in test_export() gbmtest.c:466
03/03 00:45:11.865 DEBUG|        base_utils:0268| [stdout] CHECK failed in check_bo() gbmtest.c:124
03/03 00:45:11.865 DEBUG|        base_utils:0268| [stdout] CHECK failed in test_import() gbmtest.c:502

veyron_jerry_1.8GHz_2GB
03/06 22:45:51.579 DEBUG|        base_utils:0268| [stdout] CHECK failed in check_bo() gbmtest.c:125
03/06 22:45:51.580 DEBUG|        base_utils:0268| [stdout] CHECK failed in test_import() gbmtest.c:503

Aha, are we missing the dmabuf import/export stuff on kernel 3.10 ?
Cc: littlecvr@chromium.org
Cc: -marc...@chromium.org ynovikov@chromium.org
Owner: marc...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/minigbm/+/e04c9b50d4f50ed661f06db883e77c8b56acf386

commit e04c9b50d4f50ed661f06db883e77c8b56acf386
Author: Stéphane Marchesin <marcheu@chromium.org>
Date: Sat Mar 12 06:01:35 2016

minigbm: Fill sizes[0] in gbm_bo_import

We need to give useable sizes to imported buffers, not just the ones
we create.

BUG= chromium:592681 
TEST=run the test on lumpy

Change-Id: Ife99988600607e2f4a56bbad37b48c21829701dd
Reviewed-on: https://chromium-review.googlesource.com/332448
Commit-Ready: Stéphane Marchesin <marcheu@chromium.org>
Tested-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Ilja Friedel <ihf@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[modify] https://crrev.com/e04c9b50d4f50ed661f06db883e77c8b56acf386/gbm.c

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 13 2016

Labels: merge-merged-chromeos-3.10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/0cd03be21d2a72aa436f4e97868cd6dd6299021c

commit 0cd03be21d2a72aa436f4e97868cd6dd6299021c
Author: Stéphane Marchesin <marcheu@chromium.org>
Date: Sat Mar 12 08:25:06 2016

CHROMIUM: drm/prime: Fix handle_to_fd return value in case we already have an fd

If we already have an fd we shouldn't return the fd as an error and
make user space think that something is wrong.

BUG= chromium:592681 
TEST=run gbmtest on glimmer, it passes

Change-Id: I9561d0c71ba4550e05f4130ff4974dd62250253d
Signed-off-by: Stphane Marchesin <marcheu@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/332229
Commit-Ready: Stéphane Marchesin <marcheu@chromium.org>
Tested-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Ilja Friedel <ihf@chromium.org>

[modify] https://crrev.com/0cd03be21d2a72aa436f4e97868cd6dd6299021c/drivers/gpu/drm/drm_prime.c

Status: Fixed (was: Started)
should be fixed now
Indeed, 8060.0.0 shows all green (some platforms were not tested, though, so not marking as Verified yet).
Thank you very much for fixing my bug, Stéphane!
Only 1 platform remains untested - enguarde.
The last time gbmtest ran on it was March 12th.
Labels: VerifyIn-51
Status: Verified (was: Fixed)
Bulk verified

Sign in to add a comment