ThemeServiceWin::OnDwmKeyUpdated causing assert on Windows 10 |
|||||
Issue descriptionVersion: since revision 1b7b24793aceb615c9d54ae73c0cbbd7b9480622 OS: Windows 10 - 10.0.10586.103 64-bit all crash with base::MessageLoop::AddDestructionObserver [0x00007FF6EAB6F348+24] base::win::ObjectWatcher::StartWatchingInternal [0x00007FF6EABA77EB+491] base::win::RegKey::StartWatching [0x00007FF6EAB79757+135] ThemeServiceWin::OnDwmKeyUpdated [0x00007FF6EA2ED433+211] ThemeServiceWin::ThemeServiceWin [0x00007FF6EA2ED236+150] ThemeServiceFactory::BuildServiceInstanceFor [0x00007FF6EA19B654+36] BrowserContextKeyedServiceFactory::BuildServiceInstanceFor [0x00007FF6EC9FF032+18] KeyedServiceFactory::GetServiceForContext [0x00007FF6EAFDBE37+519] DependencyManager::CreateContextServices [0x00007FF6EAFDD36D+173] BrowserContextDependencyManager::DoCreateBrowserContextServices [0x00007FF6EC9FF3BC+236] TestingProfile::Init [0x00007FF6EA83D240+608] TestingProfile::TestingProfile [0x00007FF6EA83AF8D+285] ExtensionWelcomeNotificationTest::SetUp [0x00007FF6E9AC5E6D+285] testing::Test::Run [0x00007FF6EA82B4FF+143] testing::TestInfo::Run [0x00007FF6EA82B92B+267] testing::TestCase::Run [0x00007FF6EA82B734+308] testing::internal::UnitTestImpl::RunAllTests [0x00007FF6EA82BDDE+670] testing::UnitTest::Run [0x00007FF6EA82BAFE+254] base::TestSuite::Run [0x00007FF6ED5CE44A+218] content::UnitTestTestSuite::Run [0x00007FF6EE55FED4+20] base::`anonymous namespace'::LaunchUnitTestsInternal [0x00007FF6ED5D49F3+819] base::LaunchUnitTests [0x00007FF6ED5D469C+140] main [0x00007FF6ED5F8AC9+153] __tmainCRTStartup [0x00007FF6ED4FD7EC+324] (f:\dd\vctools\crt\crtw32\startup\crt0.c:255) BaseThreadInitThunk [0x00007FFE878E8102+34] RtlUserThreadStart [0x00007FFE87C2C5B4+52] see https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%2010/builds/2366/steps/unit_tests/logs/stdio adding blame list from FYI bot to CC.
,
Mar 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5855bedc3af9746d0a68471f182dcc99bbfa3299 commit 5855bedc3af9746d0a68471f182dcc99bbfa3299 Author: wfh <wfh@chromium.org> Date: Mon Mar 07 19:38:11 2016 Revert of Monitor the system native frame color on Win 10. (patchset #4 id:60001 of https://codereview.chromium.org/1744483002/ ) Reason for revert: This breaks the win10 bot. see bug 592676 Original issue's description: > Monitor the system native frame color on Win 10. > > GetColor(COLOR_FRAME...) will now report the actual in-use color for Win 10 > native frames. This is not used yet, but will be useful for: > (a) Dynamically choosing the right incognito icon color > (b) Dynamically choosing the right COLOR_TOOLBAR_TOP_SEPARATOR > (c) Eventually, converting Win 10 to custom-drawing the frame but still > respecting the user's color choice > > BUG= 505013 , 585470 > TEST=none > > Committed: https://crrev.com/9fcf69e0bc440b16661c39c4b9f13182f0430725 > Cr-Commit-Position: refs/heads/master@{#378989} TBR=estade@chromium.org,bsep@chromium.org,pkasting@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 505013 , 585470 , 592676 Review URL: https://codereview.chromium.org/1771933002 Cr-Commit-Position: refs/heads/master@{#379611} [modify] https://crrev.com/5855bedc3af9746d0a68471f182dcc99bbfa3299/chrome/browser/themes/theme_service.cc [modify] https://crrev.com/5855bedc3af9746d0a68471f182dcc99bbfa3299/chrome/browser/themes/theme_service.h [modify] https://crrev.com/5855bedc3af9746d0a68471f182dcc99bbfa3299/chrome/browser/themes/theme_service_factory.cc [delete] https://crrev.com/cf3ba9b8d726e7b53b93dae034957b059573bb81/chrome/browser/themes/theme_service_win.cc [delete] https://crrev.com/cf3ba9b8d726e7b53b93dae034957b059573bb81/chrome/browser/themes/theme_service_win.h [modify] https://crrev.com/5855bedc3af9746d0a68471f182dcc99bbfa3299/chrome/chrome_browser.gypi
,
Mar 8 2016
revert turned the bot green - https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%2010/builds/2430
,
Mar 23 2016
This very similar assert seems to be happening on the Win10 bots: https://chromium-swarm.appspot.com/user/task/2db943735fec4810 This is based on a compile of 51.0.2687.0 (don't have exact git rev handy). [4832:5956:0322/153747:70071718:FATAL:registry.cc(64)] Check failed: key. base::debug::StackTrace::StackTrace [0x00007FF7EE166811+33] logging::LogMessage::~LogMessage [0x00007FF7EE101ADC+76] base::win::RegKey::Watcher::StartWatching [0x00007FF7EE11D8D4+100] base::win::RegKey::StartWatching [0x00007FF7EE11D857+135] ThemeServiceWin::OnDwmKeyUpdated [0x00007FF7ED898F1B+203] ThemeServiceWin::ThemeServiceWin [0x00007FF7ED898D36+150] ThemeServiceFactory::BuildServiceInstanceFor [0x00007FF7ED5D8C74+36] BrowserContextKeyedServiceFactory::BuildServiceInstanceFor [0x00007FF7F08825B2+18] KeyedServiceFactory::GetServiceForContext [0x00007FF7EE66532C+476] DependencyManager::CreateContextServices [0x00007FF7EE666895+245] BrowserContextDependencyManager::DoCreateBrowserContextServices [0x00007FF7F0882A06+246] TestingProfile::Init [0x00007FF7EDDAA1C2+690] TestingProfile::TestingProfile [0x00007FF7EDDA76E1+497] TestingProfile::Builder::Build [0x00007FF7EDDA80F3+275] TestingProfileManager::CreateTestingProfile [0x00007FF7EDDB1C2E+398] IncidentReportingServiceTest::CreateProfile [0x00007FF7ED1FE6BB+587] IncidentReportingServiceTest_ProcessWideNoUploadAfterProfile_Test::TestBody [0x00007FF7ED20561C+204] testing::Test::Run [0x00007FF7EDD982F6+278] testing::TestInfo::Run [0x00007FF7EDD9869B+267] testing::TestCase::Run [0x00007FF7EDD984A4+308] testing::internal::UnitTestImpl::RunAllTests [0x00007FF7EDD98B4E+670] testing::UnitTest::Run [0x00007FF7EDD9886E+254] base::TestSuite::Run [0x00007FF7F1795EFA+218] base::LaunchUnitTests [0x00007FF7F179D64D+1069] base::LaunchUnitTests [0x00007FF7F179D2AC+140] main [0x00007FF7F17C86F9+153] __scrt_common_main_seh [0x00007FF7F16A41F4+292] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:264) BaseThreadInitThunk [0x00007FFBB4972D92+34] RtlUserThreadStart [0x00007FFBB4CF9F64+52]
,
Mar 23 2016
,
Mar 23 2016
Also happening on FYI bot https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%2010/builds/2627/steps/unit_tests/logs/stdio
,
Mar 23 2016
That's odd. That means we couldn't open the registry key with the requested permissions. I can work around this easily. I'd like to know why this fails on these bots, but I'm not sure how one would debug on them.
,
Mar 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d73369e32f4cb2dbeec4d8080c377f545ff8640 commit 6d73369e32f4cb2dbeec4d8080c377f545ff8640 Author: pkasting <pkasting@chromium.org> Date: Wed Mar 23 10:55:06 2016 Fix DCHECK failure on bots when registry key can't be opened successfully. I don't know why this happens, but we should have this sanity check anyway. BUG= 592676 TEST=none TBR=estade Review URL: https://codereview.chromium.org/1822263002 Cr-Commit-Position: refs/heads/master@{#382825} [modify] https://crrev.com/6d73369e32f4cb2dbeec4d8080c377f545ff8640/chrome/browser/themes/theme_service_win.cc
,
Mar 23 2016
,
Mar 24 2016
Thanks for fixing - all tests pass now - https://chromium-swarm.appspot.com/user/task/2dc2d14fde3dab10 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by wfh@chromium.org
, Mar 7 2016Owner: pkasting@chromium.org
Status: Assigned (was: Untriaged)