Issue metadata
Sign in to add a comment
|
When recipe-roller creates a new roll, it should close all previous pending ones |
||||||||||||||||||||||||
Issue descriptionWhat steps will reproduce the problem? 1. Land a non-trivial recipe change 2. Let recipe-roller generate a review in another repo 3. Ignore that review for a while 4. Land another change 5. Let recipe-roller generate another review What is the expected output? What do you see instead? Recipe-roller should close the previous review, now that it has been replaced by the more recent one. Instead, you just get a ton of nearly-identical emails in a row and you have to inspect them carefully to figure out which one should actually be reviewed. Please use labels and text to provide additional information.
,
Mar 7 2016
oldest: https://chromereviews.googleplex.com/366567014/ next: https://chromereviews.googleplex.com/367577013/ one that got attention for some reason: https://chromereviews.googleplex.com/376607013/ newest that I finally landed: https://chromereviews.googleplex.com/376617013/
,
Mar 8 2016
In the future we should effectively be landing one change at a time, right? So each should be queued, landing over the previous one after downstream is caught up.
,
Mar 8 2016
I believe this is a different mode. The recipe roller should close the old issues, and post a comment about moving to the new CL. That's not really possible with the current design, though, because it doesn't have any idea of continuity, but only the raw diff, I think. But this would be very nice to have for the user.
,
Apr 26 2016
,
Nov 23 2016
,
Jan 10 2017
I believe this is fixed with https://chromium-review.googlesource.com/c/371918/ . We could do some further refinements like mentioned here, such as posting comments on old CLs if needed. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by martiniss@chromium.org
, Mar 7 2016